RESOLVED FIXED 203115
Use constexpr in more places and remove some unnecessary external linkage. 
https://bugs.webkit.org/show_bug.cgi?id=203115
Summary Use constexpr in more places and remove some unnecessary external linkage.
Mark Lam
Reported 2019-10-17 11:19:12 PDT
...
Attachments
proposed patch. (46.93 KB, patch)
2019-10-17 11:46 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (47.32 KB, patch)
2019-10-17 11:58 PDT, Mark Lam 		ysuzuki: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2019-10-17 11:46:20 PDT
Created attachment 381209 [details] proposed patch.
Mark Lam
Comment 2 2019-10-17 11:58:25 PDT
Created attachment 381211 [details] proposed patch.
EWS Watchlist
Comment 3 2019-10-17 14:22:19 PDT
Comment on attachment 381211 [details] proposed patch. Attachment 381211 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/13144331 New failing tests: mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla
Mark Lam
Comment 4 2019-10-17 14:58:34 PDT
(In reply to Build Bot from comment #3) > New failing tests: > mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla This is the flaky test again. It can't possibly be related to this patch since all I'm doing is effectively changing const to constexpr.
Yusuke Suzuki
Comment 5 2019-10-17 15:03:04 PDT
Comment on attachment 381211 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=381211&action=review r=me > Source/JavaScriptCore/jit/GPRInfo.cpp:-47 > -#endif Nice.
Mark Lam
Comment 6 2019-10-17 15:20:03 PDT
Thanks for the review. Landed in r251263: <http://trac.webkit.org/r251263>.
Radar WebKit Bug Importer
Comment 7 2019-10-17 15:21:19 PDT
<rdar://problem/56387812>
Daniel Bates
Comment 8 2019-10-17 20:13:43 PDT
Comment on attachment 381211 [details] proposed patch. This patch is good. The optimal solution is just use constexpr (read: not static constexpr) for all var defns as constexpr var defs have internal linkage.
Note You need to log in before you can comment on or make changes to this bug.