Bug 203114 - Remove unused WKWebsiteDataStore setter SPI
Summary: Remove unused WKWebsiteDataStore setter SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-17 11:14 PDT by Alex Christensen
Modified: 2019-10-28 17:10 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.65 KB, patch)
2019-10-17 11:15 PDT, Alex Christensen 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-10-17 11:14:48 PDT 
Remove unused WKWebsiteDataStore setter SPI
Comment 1 Alex Christensen 2019-10-17 11:15:28 PDT 
Created attachment 381203 [details]
Patch
Comment 2 Alex Christensen 2019-10-17 11:19:32 PDT 
Comment on attachment 381203 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381203&action=review

> Source/WebKit/ChangeLog:8
> +        They have been replaced by _WKWebsiteDataStoreConfiguration SPI which was adopted in rdar://problem/56349165

I'll wait for this radar to be integrated before landing.
Comment 3 Alex Christensen 2019-10-28 14:52:22 PDT 
http://trac.webkit.org/r251675
Comment 4 Radar WebKit Bug Importer 2019-10-28 14:53:19 PDT 
<rdar://problem/56686031>
Comment 5 Alex Christensen 2019-10-28 17:10:21 PDT 
Comment on attachment 381203 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381203&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:-56
> -@property (nonatomic, setter=_setAllowsCellularAccess:) BOOL _allowsCellularAccess WK_API_DEPRECATED_WITH_REPLACEMENT("_WKWebsiteDataStoreConfiguration.allowsCellularAccess", macos(10.13.4, WK_MAC_TBA), ios(11.3, WK_IOS_TBA));

Somebody's still using this.  Grumble grumble.  Will not break their build again.