RESOLVED FIXED 203114
Remove unused WKWebsiteDataStore setter SPI 
https://bugs.webkit.org/show_bug.cgi?id=203114
Summary Remove unused WKWebsiteDataStore setter SPI
Alex Christensen
Reported 2019-10-17 11:14:48 PDT
Remove unused WKWebsiteDataStore setter SPI
Attachments
Patch (6.65 KB, patch)
2019-10-17 11:15 PDT, Alex Christensen 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-10-17 11:15:28 PDT
Created attachment 381203 [details] Patch
Alex Christensen
Comment 2 2019-10-17 11:19:32 PDT
Comment on attachment 381203 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381203&action=review > Source/WebKit/ChangeLog:8 > + They have been replaced by _WKWebsiteDataStoreConfiguration SPI which was adopted in rdar://problem/56349165 I'll wait for this radar to be integrated before landing.
Alex Christensen
Comment 3 2019-10-28 14:52:22 PDT
http://trac.webkit.org/r251675
Radar WebKit Bug Importer
Comment 4 2019-10-28 14:53:19 PDT
<rdar://problem/56686031>
Alex Christensen
Comment 5 2019-10-28 17:10:21 PDT
Comment on attachment 381203 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381203&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:-56 > -@property (nonatomic, setter=_setAllowsCellularAccess:) BOOL _allowsCellularAccess WK_API_DEPRECATED_WITH_REPLACEMENT("_WKWebsiteDataStoreConfiguration.allowsCellularAccess", macos(10.13.4, WK_MAC_TBA), ios(11.3, WK_IOS_TBA)); Somebody's still using this. Grumble grumble. Will not break their build again.
Note You need to log in before you can comment on or make changes to this bug.