Bug 203090 - FileSystemDirectoryReader / FileSystemEntry should not prevent entering the back/forward cache
Summary: FileSystemDirectoryReader / FileSystemEntry should not prevent entering the b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 202293
  Show dependency tree / graph
 
Reported: 2019-10-17 09:43 PDT by Chris Dumez
Modified: 2019-10-24 12:09 PDT (History)
13 users (show)

See Also:

Attachments
Patch (23.16 KB, patch)
2019-10-23 13:09 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (23.27 KB, patch)
2019-10-23 13:17 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (22.10 KB, patch)
2019-10-23 13:39 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-10-17 09:43:10 PDT 
FileSystemDirectoryReader should not prevent entering the back/forward cache.
Comment 1 Radar WebKit Bug Importer 2019-10-23 13:01:54 PDT 
<rdar://problem/56550805>
Comment 2 Chris Dumez 2019-10-23 13:09:51 PDT 
Created attachment 381717 [details]
Patch
Comment 3 Chris Dumez 2019-10-23 13:17:24 PDT 
Created attachment 381720 [details]
Patch
Comment 4 Chris Dumez 2019-10-23 13:39:07 PDT 
Created attachment 381723 [details]
Patch
Comment 5 Geoffrey Garen 2019-10-23 14:09:35 PDT 
Comment on attachment 381723 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2019-10-23 16:25:38 PDT 
Comment on attachment 381723 [details]
Patch

Clearing flags on attachment: 381723

Committed r251509: <https://trac.webkit.org/changeset/251509>
Comment 7 WebKit Commit Bot 2019-10-23 16:25:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Truitt Savell 2019-10-24 12:03:10 PDT 
The two new tests added in https://trac.webkit.org/changeset/251509/webkit
are timing out on windows constantly and slowing down win EWS.

History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=editing%2Fpasteboard%2Fentries-api%2FDirectoryEntry-getFile-back-forward-cache.html&test=editing%2Fpasteboard%2Fentries-api%2FDirectoryReader-readEntries-back-forward-cache.html

We missed this earlier due to Windows testing being broken yesterday.
Comment 9 Chris Dumez 2019-10-24 12:09:21 PDT 
(In reply to Truitt Savell from comment #8)
> The two new tests added in https://trac.webkit.org/changeset/251509/webkit
> are timing out on windows constantly and slowing down win EWS.
> 
> History:
> https://results.webkit.org/?suite=layout-tests&suite=layout-
> tests&test=editing%2Fpasteboard%2Fentries-api%2FDirectoryEntry-getFile-back-
> forward-cache.html&test=editing%2Fpasteboard%2Fentries-api%2FDirectoryReader-
> readEntries-back-forward-cache.html
> 
> We missed this earlier due to Windows testing being broken yesterday.

Fixed in <https://trac.webkit.org/changeset/251550>.