MediaKeySession / WebKitMediaKeySession should not prevent entering the back/forward cache

[Chris Dumez]

MediaKeySession should not prevent entering the back/forward cache.

[Chris Dumez]

Created attachment 382392 [details]
WIP Patch

[Chris Dumez]

Created attachment 382395 [details]
WIP Patch

[Radar WebKit Bug Importer]

<rdar://problem/56780551>

[Chris Dumez]

Created attachment 382457 [details]
Patch

[Chris Dumez]

ping review?

[youenn fablet]

Comment on attachment 382457 [details]
Patch

How do we make sure we have not missed to enqueue one event or a task?
We probably do not have a lot of coverage there.

[Chris Dumez]

(In reply to youenn fablet from comment #6)
> Comment on attachment 382457 [details]
> Patch
> 
> How do we make sure we have not missed to enqueue one event or a task?
> We probably do not have a lot of coverage there.

If you try to dispatch events while in the cache, then we would hit assertions.

[WebKit Commit Bot]

Comment on attachment 382457 [details]
Patch

Clearing flags on attachment: 382457

Committed r251993: <https://trac.webkit.org/changeset/251993>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Truitt Savell]

The changes in https://trac.webkit.org/changeset/251993/webkit

broke platform/mac/media/encrypted-media/fps-generateRequest.html

History:
https://results.webkit.org/?suite=layout-tests&test=platform%2Fmac%2Fmedia%2Fencrypted-media%2Ffps-generateRequest.html

Diff:
--- /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/platform/mac/media/encrypted-media/fps-generateRequest-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/platform/mac/media/encrypted-media/fps-generateRequest-actual.txt
@@ -6,6 +6,6 @@
 RUN(session = keys.createSession())
 EXPECTED (session != 'null') OK
 RUN(promise = session.generateRequest("sinf", initData))
-Promise resolved OK
+Promise rejected FAIL
 END OF TEST

[Truitt Savell]

Reverted r251993 for reason:

Broke platform/mac/media/encrypted-media/fps-generateRequest.html on Mojave+

Committed r252008: <https://trac.webkit.org/changeset/252008>

[Chris Dumez]

Created attachment 382787 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 382787 [details]
Patch

Rejecting attachment 382787 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 382787, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/13212916

[Chris Dumez]

Created attachment 382795 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 382795 [details]
Patch

Clearing flags on attachment: 382795

Committed r252033: <https://trac.webkit.org/changeset/252033>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.