Bug 203084 – Cleanup dead initializations in JSC code

• Status: RESOLVED
• Resolution: INVALID
• Component: New Bugs

[Paulo Matos]

Cleanup dead initializations in JSC code

[Paulo Matos]

Created attachment 381193 [details]
Patch

[Saam Barati]

Comment on attachment 381193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381193&action=review

> Source/JavaScriptCore/runtime/TypeSet.cpp:-306
> -        hasAnItem = true;

Even though this is dead, it’s kind of nice to keep it in in places like this so we don’t forget to do it if we add new cases in the future.

[Paulo Matos]

Created attachment 381783 [details]
Patch

[Paulo Matos]

Created attachment 381790 [details]
Patch

[Paulo Matos]

Created attachment 388231 [details]
Patch

[Darin Adler]

Comment on attachment 388231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388231&action=review

> Source/JavaScriptCore/API/tests/TypedArrayCTest.cpp:194
> -        typedArray = JSObjectMakeTypedArrayWithArrayBufferAndOffset(context, type, data, 1, length-1, &exception);
> +        JSObjectMakeTypedArrayWithArrayBufferAndOffset(context, type, data, 1, length-1, &exception);

This change does not yet seem quite right to me. Why change this call to JSObjectMakeTypedArrayWithArrayBufferAndOffset and not the next call just below after the if statement, which also sets a value of typedArray that is never looked at?

[Darin Adler]

Comment on attachment 388231 [details]
Patch

Also: A number of these are a bit unsafe if we add any new code. The stores are only dead because there is no further code using the results after this point; not sure they are all improvements.

[Paulo Matos]

(In reply to Darin Adler from comment #7)
> Comment on attachment 388231 [details]
> Patch
> 
> Also: A number of these are a bit unsafe if we add any new code. The stores
> are only dead because there is no further code using the results after this
> point; not sure they are all improvements.

Thanks for the comments - I will close this for now.

[Mark Lam]

(In reply to Paulo Matos from comment #8)
> (In reply to Darin Adler from comment #7)
> > Comment on attachment 388231 [details]
> > Patch
> > 
> > Also: A number of these are a bit unsafe if we add any new code. The stores
> > are only dead because there is no further code using the results after this
> > point; not sure they are all improvements.
> 
> Thanks for the comments - I will close this for now.

FYI, if you want to silence the warning, you can always add a UNUSED_PARAM(value).