Bug 203071 - Clean up some includes to improve WebKit2 build speed
Summary: Clean up some includes to improve WebKit2 build speed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-16 20:29 PDT by Tim Horton
Modified: 2019-10-21 01:28 PDT (History)
18 users (show)

See Also:

Attachments
Patch (28.63 KB, patch)
2019-10-16 20:30 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (28.63 KB, patch)
2019-10-16 20:38 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (28.63 KB, patch)
2019-10-16 20:43 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (27.10 KB, patch)
2019-10-16 21:31 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (27.59 KB, patch)
2019-10-16 21:51 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (27.58 KB, patch)
2019-10-16 21:59 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (28.08 KB, patch)
2019-10-16 22:20 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (28.59 KB, patch)
2019-10-16 22:52 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (31.91 KB, patch)
2019-10-19 16:22 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews212 for win-future (13.74 MB, application/zip)
2019-10-19 18:16 PDT, EWS Watchlist 		no flags Details
Patch (32.14 KB, patch)
2019-10-19 18:28 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (33.02 KB, patch)
2019-10-19 19:17 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (33.02 KB, patch)
2019-10-19 20:03 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (34.56 KB, patch)
2019-10-19 23:28 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (35.12 KB, patch)
2019-10-20 02:06 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (35.12 KB, patch)
2019-10-20 02:23 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (35.13 KB, patch)
2019-10-20 21:51 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (35.17 KB, patch)
2019-10-20 23:10 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (16) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-10-16 20:29:01 PDT 
Clean up some includes to improve WebKit2 build speed
Comment 1 Tim Horton 2019-10-16 20:30:39 PDT 
Created attachment 381152 [details]
Patch
Comment 2 Tim Horton 2019-10-16 20:38:02 PDT 
Created attachment 381153 [details]
Patch
Comment 3 Wenson Hsieh 2019-10-16 20:38:48 PDT 
Comment on attachment 381153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381153&action=review

r=mews

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:235
> +IOSurface::~IOSurface()

Nit - = default?
Comment 4 Tim Horton 2019-10-16 20:43:06 PDT 
Created attachment 381154 [details]
Patch
Comment 5 Tim Horton 2019-10-16 21:31:21 PDT 
Created attachment 381155 [details]
Patch
Comment 6 Tim Horton 2019-10-16 21:51:41 PDT 
Created attachment 381158 [details]
Patch
Comment 7 Tim Horton 2019-10-16 21:59:16 PDT 
Created attachment 381161 [details]
Patch
Comment 8 Tim Horton 2019-10-16 22:20:27 PDT 
Created attachment 381164 [details]
Patch
Comment 9 Tim Horton 2019-10-16 22:52:40 PDT 
Created attachment 381168 [details]
Patch
Comment 10 Tim Horton 2019-10-16 23:35:59 PDT 
I guess I should wait till I can build for iOS :|
Comment 11 Tim Horton 2019-10-19 16:22:07 PDT 
Created attachment 381377 [details]
Patch
Comment 12 EWS Watchlist 2019-10-19 18:16:28 PDT 
Comment on attachment 381377 [details]
Patch

Attachment 381377 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13153497

New failing tests:
http/tests/misc/repeat-open-cancel.html
Comment 13 EWS Watchlist 2019-10-19 18:16:31 PDT 
Created attachment 381382 [details]
Archive of layout-test-results from ews212 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 14 Tim Horton 2019-10-19 18:28:50 PDT 
Created attachment 381385 [details]
Patch
Comment 15 Tim Horton 2019-10-19 19:17:52 PDT 
Created attachment 381386 [details]
Patch
Comment 16 Tim Horton 2019-10-19 20:03:59 PDT 
Created attachment 381387 [details]
Patch
Comment 17 Tim Horton 2019-10-19 23:23:21 PDT 
WTF is so special about wincairo
Comment 18 Tim Horton 2019-10-19 23:28:02 PDT 
Created attachment 381390 [details]
Patch
Comment 19 Tim Horton 2019-10-20 02:06:05 PDT 
Created attachment 381392 [details]
Patch
Comment 20 Tim Horton 2019-10-20 02:23:40 PDT 
Created attachment 381393 [details]
Patch
Comment 21 Tim Horton 2019-10-20 21:51:31 PDT 
Created attachment 381400 [details]
Patch
Comment 22 Tim Horton 2019-10-20 23:10:05 PDT 
Created attachment 381403 [details]
Patch
Comment 23 Tim Horton 2019-10-21 00:40:55 PDT 
🎉

(Can’t wait for the internal build failures to start streaming in)
Comment 24 WebKit Commit Bot 2019-10-21 01:26:03 PDT 
Comment on attachment 381403 [details]
Patch

Clearing flags on attachment: 381403

Committed r251361: <https://trac.webkit.org/changeset/251361>
Comment 25 WebKit Commit Bot 2019-10-21 01:26:05 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 26 Radar WebKit Bug Importer 2019-10-21 01:28:44 PDT 
<rdar://problem/56455005>