Bug 203066 - Remove unused _WKProcessPoolConfiguration SPI
Summary: Remove unused _WKProcessPoolConfiguration SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-16 17:32 PDT by Alex Christensen
Modified: 2020-02-26 17:40 PST (History)
2 users (show)

See Also:

Attachments
Patch (22.33 KB, patch)
2019-10-16 17:37 PDT, Alex Christensen 		youennf: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-10-16 17:32:20 PDT 
Remove unused _WKProcessPoolConfiguration SPI
Comment 1 Alex Christensen 2019-10-16 17:37:33 PDT 
Created attachment 381139 [details]
Patch
Comment 2 Alex Christensen 2019-10-16 17:39:02 PDT 
Comment on attachment 381139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381139&action=review

> Source/WebKit/ChangeLog:8
> +        After rdar://problem/56260478 this is not used, so away it goes!

(I'll wait for this radar to be integrated before landing this)
Comment 3 Alex Christensen 2019-11-12 07:18:39 PST 
https://trac.webkit.org/changeset/251676/webkit
Comment 4 Radar WebKit Bug Importer 2019-11-12 07:19:20 PST 
<rdar://problem/57115508>
Comment 5 Alex Christensen 2019-11-12 07:20:08 PST 
Comment on attachment 381139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381139&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:-334
> -- (BOOL)suppressesConnectionTerminationOnSystemChange

This wasn't unused after all.  rdar://problem/57008444
Comment 6 Alex Christensen 2019-11-12 07:27:44 PST 
http://trac.webkit.org/r252364 reverted part of this.
Comment 7 Alex Christensen 2019-11-12 07:47:33 PST 
rdar://problem/57115922 tracks the revert
Comment 8 Alex Christensen 2019-11-12 09:30:26 PST 
http://trac.webkit.org/r252368 reverted the rest of this.
Comment 9 Alex Christensen 2020-02-26 17:40:57 PST 
This has been recommitted in https://bugs.webkit.org/show_bug.cgi?id=205751