Some of our simulator testers are filling up their hardrives alarmingly quickly, probably due to our habit of recreating simulators constantly. We should do some cleanup every time we tear down automatically created simulators.
<rdar://problem/56344905>
Created attachment 381119 [details] Patch
Comment on attachment 381119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381119&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:483 > + for directory in host.filesystem.glob('/tmp/com.apple.CoreSimulator.SimDevice.*'): will this work fine for windows?
Comment on attachment 381119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381119&action=review >> Tools/Scripts/webkitpy/xcode/simulated_device.py:483 >> + for directory in host.filesystem.glob('/tmp/com.apple.CoreSimulator.SimDevice.*'): > > will this work fine for windows? No, but you can't initialize simulators if you aren't on a Mac, and if we don't have initialized simulators, we early return on line 470.
Comment on attachment 381119 [details] Patch Clearing flags on attachment: 381119 Committed r251793: <https://trac.webkit.org/changeset/251793>
All reviewed patches have been landed. Closing bug.