Bug 203056 - Simulator testers are filling up
Summary: Simulator testers are filling up
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-16 14:51 PDT by Jonathan Bedard
Modified: 2019-10-30 12:43 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.72 KB, patch)
2019-10-16 15:04 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-10-16 14:51:21 PDT
Some of our simulator testers are filling up their hardrives alarmingly quickly, probably due to our habit of recreating simulators constantly. We should do some cleanup every time we tear down automatically created simulators.
Comment 1 Jonathan Bedard 2019-10-16 14:51:50 PDT
<rdar://problem/56344905>
Comment 2 Jonathan Bedard 2019-10-16 15:04:19 PDT
Created attachment 381119 [details]
Patch
Comment 3 Aakash Jain 2019-10-30 11:40:59 PDT
Comment on attachment 381119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381119&action=review

> Tools/Scripts/webkitpy/xcode/simulated_device.py:483
> +        for directory in host.filesystem.glob('/tmp/com.apple.CoreSimulator.SimDevice.*'):

will this work fine for windows?
Comment 4 Jonathan Bedard 2019-10-30 11:44:43 PDT
Comment on attachment 381119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381119&action=review

>> Tools/Scripts/webkitpy/xcode/simulated_device.py:483
>> +        for directory in host.filesystem.glob('/tmp/com.apple.CoreSimulator.SimDevice.*'):
> 
> will this work fine for windows?

No, but you can't initialize simulators if you aren't on a Mac, and if we don't have initialized simulators, we early return on line 470.
Comment 5 WebKit Commit Bot 2019-10-30 12:43:42 PDT
Comment on attachment 381119 [details]
Patch

Clearing flags on attachment: 381119

Committed r251793: <https://trac.webkit.org/changeset/251793>
Comment 6 WebKit Commit Bot 2019-10-30 12:43:44 PDT
All reviewed patches have been landed.  Closing bug.