Bug 203053 - TestWebKitAPI.ScrollViewScrollabilityTests.ScrollableWithOverflowHiddenAndInputView is failing on iPad simulator
Summary: TestWebKitAPI.ScrollViewScrollabilityTests.ScrollableWithOverflowHiddenAndInp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-16 14:34 PDT by Russell Epstein
Modified: 2019-10-21 18:31 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2019-10-16 14:39 PDT, Russell Epstein 		no flags Details | Formatted Diff | Diff
Patch (1.74 KB, patch)
2019-10-21 14:49 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Russell Epstein 2019-10-16 14:34:18 PDT 
The following API test is consistently failing on iPad Simulator bots:

TestWebKitAPI.ScrollViewScrollabilityTests.ScrollableWithOverflowHiddenAndInputView

Error:

Failed

    TestWebKitAPI.ScrollViewScrollabilityTests.ScrollableWithOverflowHiddenAndInputView
        LEAK: 1 WebProcessPool
        LEAK: 1 WebPageProxy
        
        /Volumes/Data/slave/ios-simulator-13-debug/build/Tools/TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:97
        Expected equality of these values:
          [[webView scrollView] isScrollEnabled]
            Which is: false
          __objc_yes
            Which is: true
Comment 1 Russell Epstein 2019-10-16 14:36:18 PDT 
rdar://53823611
Comment 2 Russell Epstein 2019-10-16 14:39:28 PDT 
Created attachment 381110 [details]
Patch
Comment 3 Russell Epstein 2019-10-16 14:40:50 PDT 
(In reply to Russell Epstein from comment #2)
> Created attachment 381110 [details]
> Patch

This patch was provided by Wenson as a potential workaround, as this test is not designed to pass on iPad.
Comment 4 Simon Fraser (smfr) 2019-10-21 14:49:42 PDT 
Created attachment 381461 [details]
Patch
Comment 5 WebKit Commit Bot 2019-10-21 18:31:29 PDT 
Comment on attachment 381461 [details]
Patch

Clearing flags on attachment: 381461

Committed r251407: <https://trac.webkit.org/changeset/251407>
Comment 6 WebKit Commit Bot 2019-10-21 18:31:31 PDT 
All reviewed patches have been landed.  Closing bug.