RESOLVED FIXED 203049
fast/events/ios/forward-delete-in-editable.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=203049
Summary fast/events/ios/forward-delete-in-editable.html is a flaky failure
Daniel Bates
Reported 2019-10-16 12:14:06 PDT
Sometimes fast/events/ios/forward-delete-in-editable.html fails. I suspect this is because it was written using a workaround for <rdar://problem/45772078>, which meant it waited until a blur event to check the test result. The assumption behind the workaround was that the keyboard code would call back to ask WebKit to perform the forward delete BEFORE the WebKit would blur() the field. There is no such guarantee. Instead we should do what we couldn't do at the time of writing this test and check that we receive a DOM key up event before checking the result.
Attachments
Patch (2.47 KB, patch)
2019-10-16 12:23 PDT, Daniel Bates
no flags
Daniel Bates
Comment 1 2019-10-16 12:14:12 PDT
Daniel Bates
Comment 2 2019-10-16 12:23:29 PDT
Daniel Bates
Comment 3 2019-10-18 15:22:52 PDT
Thanks Wenson!
Daniel Bates
Comment 4 2019-10-18 15:24:01 PDT
Comment on attachment 381096 [details] Patch Clearing flags on attachment: 381096 Committed r251301: <https://trac.webkit.org/changeset/251301>
Daniel Bates
Comment 5 2019-10-18 15:24:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.