Bug 203048 - Rename PageCache to BackForwardCache
Summary: Rename PageCache to BackForwardCache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 202293
  Show dependency tree / graph
 
Reported: 2019-10-16 11:57 PDT by Chris Dumez
Modified: 2019-10-16 18:45 PDT (History)
41 users (show)

See Also:

Attachments
Patch (375.91 KB, patch)
2019-10-16 14:48 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (376.59 KB, patch)
2019-10-16 15:00 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (378.01 KB, patch)
2019-10-16 15:53 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (378.40 KB, patch)
2019-10-16 16:30 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (377.94 KB, patch)
2019-10-16 17:59 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-10-16 11:57:06 PDT 
Rename PageCache to BackForwardCache for clarity and consistency with the UIProcess's WebBackForwardCache.
Comment 1 Chris Dumez 2019-10-16 14:48:00 PDT 
Created attachment 381111 [details]
Patch
Comment 2 EWS Watchlist 2019-10-16 14:48:41 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Chris Dumez 2019-10-16 15:00:12 PDT 
Created attachment 381117 [details]
Patch
Comment 4 Chris Dumez 2019-10-16 15:53:11 PDT 
Created attachment 381126 [details]
Patch
Comment 5 Chris Dumez 2019-10-16 16:30:05 PDT 
Created attachment 381132 [details]
Patch
Comment 6 Alex Christensen 2019-10-16 17:41:09 PDT 
Comment on attachment 381132 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381132&action=review

> Source/WebCore/ChangeLog:8
> +        Rename PageCache to BackForwardCache for clarity and consistency with the UIProcess's WebBackForwardCache.

And Chromium!
Comment 7 Chris Dumez 2019-10-16 17:59:39 PDT 
Created attachment 381143 [details]
Patch
Comment 8 WebKit Commit Bot 2019-10-16 18:44:29 PDT 
Comment on attachment 381143 [details]
Patch

Clearing flags on attachment: 381143

Committed r251220: <https://trac.webkit.org/changeset/251220>
Comment 9 WebKit Commit Bot 2019-10-16 18:44:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-10-16 18:45:19 PDT 
<rdar://problem/56355134>