Bug 203044 – Load event must be fired only for the SVG structurally external elements and the outermost SVG element

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Said Abou-Hallawa]

Open the attached test case.

Result: A green rectangle is displayed.
Expected: Two messages are displayed below the green rectangle saying two images were loaded. One is external and the other is data URI.

[Said Abou-Hallawa]

Created attachment 381086 [details]
Image for the test case

[Said Abou-Hallawa]

Created attachment 381087 [details]
test case

[Said Abou-Hallawa]

https://www.w3.org/TR/SVG/changes.html#interact
https://www.w3.org/TR/SVG/interact.html

[Said Abou-Hallawa]

Created attachment 381235 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 381235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381235&action=review

> Source/WebCore/svg/SVGScriptElement.h:76
> +    Timer* loadEventTimer() final { return &m_loadEventTimer; }

Seems weird to expose the timer outside the class. Does anyone use it?

[EWS Watchlist]

Comment on attachment 381235 [details]
Patch

Attachment 381235 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13144911

New failing tests:
fast/html/marquee-reparent-check.html
svg/custom/image-load-event.html
fast/dom/crash-moving-subtree-between-documents.html
fast/dom/focus-style-resolution.html

[EWS Watchlist]

Created attachment 381249 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Said Abou-Hallawa]

Created attachment 381312 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 381312 [details]
Patch

Clearing flags on attachment: 381312

Committed r251290: <https://trac.webkit.org/changeset/251290>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56413481>

[Nikolas Zimmermann]

I am confused: svg/W3C-SVG-1.1/interact-events-01-b.svg should be affected by this patch, but I see no updates of the tests or the expectation.

The test exercises SVGLoad event dispatch to e.g. <rect> elements which previously finishParsingChildren() triggered, no?

mac/svg/W3C-SVG-1.1/interact-events-01-b-expected.png still shows the "old" expectation.

Said, can you clarify this?

[Carlos Alberto Lopez Perez]

Comment on attachment 381312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381312&action=review

> LayoutTests/imported/w3c/ChangeLog:16
> +        * web-platform-tests/svg/images/20x20.png: Added.
> +        Add an image which is referenced by these tests:
> +            web-platform-tests/svg/import/styling-pres-02-f-manual.svg
> +            web-platform-tests/svg/import/struct-use-01-t-manual.svg
> +            web-platform-tests/svg/import/interact-events-02-b-manual.svg

Have this fix been proposed back to WPT?
I don't see the file svg/images/20x20.png on the WPT repository.
Its there any open PR for it?