Bug 203026 – Turn on IOSurface support in the iOS Simulator

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Turn on IOSurface support in the iOS Simulator

[Tim Horton]

Created attachment 381055 [details]
Patch

[Tim Horton]

<rdar://problem/46098948>

[Tim Horton]

Comment on attachment 381055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381055&action=review

> LayoutTests/platform/ios/TestExpectations:3389
> +# https://bugs.webkit.org/show_bug.cgi?id=175736

See also rdar://problem/31177990 and related

[Tim Horton]

Actually we'll use <rdar://problem/56320993> for this.

[Tim Horton]

Created attachment 381056 [details]
Patch

[Tim Horton]

API test failures look real

[Alexey Proskuryakov]

We need to move iOS testers to macOS Catalina and re-test.

[Tim Horton]

Actually I can repro the API test failures locally... so I have more digging to do.

[Tim Horton]

Created attachment 381651 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 381651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381651&action=review

Exciting!

Still need to update host OS in the infrastructure to properly test (even in EWS)...

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:6391
> +    // FIXME: We should be able to use hardware snapshotting in the simulator.

Bug link?

[Tim Horton]

Created attachment 382143 [details]
Patch

[EWS Watchlist]

Comment on attachment 382143 [details]
Patch

Attachment 382143 [details] did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/13187034

New failing tests:
mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-dfg-eager-no-cjit-validate-phases

[Tim Horton]

Created attachment 382382 [details]
Patch

[Said Abou-Hallawa]

Comment on attachment 382382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382382&action=review

> LayoutTests/fast/images/exif-orientation-canvas-expected.html:115
> +            var names = [
> +                { resource: "resources/exif-orientation-1-ul.jpg",  id : "canvas1" },
> +                { resource: "resources/exif-orientation-1-ul.jpg",  id : "canvas2" },
> +                { resource: "resources/exif-orientation-1-ul.jpg",  id : "canvas3" },
> +                { resource: "resources/exif-orientation-1-ul.jpg",  id : "canvas4" },
> +                { resource: "resources/exif-orientation-1-ul.jpg",  id : "canvas5" },
> +                { resource: "resources/exif-orientation-1-ul.jpg",  id : "canvas6" },
> +                { resource: "resources/exif-orientation-1-ul.jpg",  id : "canvas7" },
> +                { resource: "resources/exif-orientation-1-ul.jpg",  id : "canvas8" },
> +                { resource: "resources/exif-orientation-1-ul.jpg",  id : "canvas9" }
> +            ];
> +
> +            var drawCount = 0;
> +
> +            names.forEach(function(name) {
> +                var image = new Image;
> +                image.src = name.resource;
> +                image.decode().then(() => {
> +                    let canvas = document.getElementById(name.id);
> +                    canvas.width = image.width;
> +                    canvas.height = image.height;
> +                    let context = canvas.getContext("2d");
> +                    context.drawImage(image, 0, 0, canvas.width, canvas.height);
> +                    if (++drawCount == names.length) {
> +                        if (window.testRunner)
> +                            window.testRunner.notifyDone();
> +                    }
> +                });
> +            });

Since the canvases are drawing the same image, this code can be simplified like this:

    var image = new Image;
    image.src = "resources/exif-orientation-1-ul.jpg";
    image.decode().then(() => {
        const canvases = document.getElementsByTagName('canvas');
        for (let canvas of canvases) {
            canvas.width = image.width;
            canvas.height = image.height;
            let context = canvas.getContext("2d");
            context.drawImage(image, 0, 0, canvas.width, canvas.height);
        }
        if (window.testRunner)
            window.testRunner.notifyDone();
    });

[Tim Horton]

Created attachment 382390 [details]
Patch

[Dean Jackson]

Comment on attachment 382390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382390&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:342
> +        unsigned char *rgba = (unsigned char *)calloc(viewWidthInPixels * viewHeightInPixels * 4, sizeof(unsigned char));

uint8_t?

or Uint8ClampedArray::tryCreateUninitialized?

[Dean Jackson]

Comment on attachment 382390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382390&action=review

> LayoutTests/fast/images/exif-orientation-canvas-expected.html:91
> +                const canvases = document.getElementsByTagName('canvas');
> +                for (let canvas of canvases) {

document.querySelectorAll("canvas").forEach(canvas => {
  // draw
});

[Tim Horton]

Created attachment 382492 [details]
Patch

[EWS Watchlist]

Comment on attachment 382492 [details]
Patch

Attachment 382492 [details] did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/13196833

New failing tests:
mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-dfg-eager-no-cjit-validate-phases

[WebKit Commit Bot]

Comment on attachment 382492 [details]
Patch

Clearing flags on attachment: 382492

Committed r251896: <https://trac.webkit.org/changeset/251896>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.