Bug 203025 - Web Inspector: Network: updates when toggling resource caching should be sent to every connected target
Summary: Web Inspector: Network: updates when toggling resource caching should be sent...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
Keywords: InRadar
Depends on:
Reported: 2019-10-15 22:20 PDT by Devin Rousso
Modified: 2019-10-17 02:08 PDT (History)
5 users (show)

See Also:

Patch (1.40 KB, patch)
2019-10-16 15:21 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-10-15 22:20:39 PDT
(In reply to Joseph Pecoraro from comment <https://webkit.org/b/200384#36>)
> > Source/WebInspectorUI/UserInterface/Base/Main.js:2759
> > +    let target = WI.assumingMainTarget();
> > +    target.NetworkAgent.setResourceCachingDisabled(WI.settings.resourceCachingDisabled.value);
> Whoa! NetworkAgent should work across multiple targets. So this is probably an existing bug and should just iterate all targets. (this could be pulled out into its own bug fix)
>     for (let target of WI.targets) {
>         if (target.NetworkAgent)
>             target.NetworkAgent.setResourceCachingDisabled(WI.settings. resourceCachingDisabled.value);
>     }
Comment 1 Devin Rousso 2019-10-16 15:21:05 PDT
Created attachment 381121 [details]

This patch requires <https://webkit.org/b/200384>.
Comment 2 Joseph Pecoraro 2019-10-16 15:23:26 PDT
Comment on attachment 381121 [details]

Comment 3 WebKit Commit Bot 2019-10-17 02:05:51 PDT
Comment on attachment 381121 [details]

Clearing flags on attachment: 381121

Committed r251229: <https://trac.webkit.org/changeset/251229>
Comment 4 WebKit Commit Bot 2019-10-17 02:05:53 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-10-17 02:08:57 PDT