Bug 203024 - DumpRenderTree should clear WTFLogChannelState::OnWithAccumulation state set by testRunner.accummulateLogsForChannel
Summary: DumpRenderTree should clear WTFLogChannelState::OnWithAccumulation state set ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-15 21:06 PDT by Fujii Hironori
Modified: 2019-10-16 18:57 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.24 KB, patch)
2019-10-15 21:15 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-10-15 21:06:50 PDT 
If a test case calls testRunner.accummulateLogsForChannel("IndexedDB"),
all subsequent IndexedDB tests dumps the log.
This is bloating DumpRenderTree log because DumpRenderTree is run with --debug-rwt-logging switch.
For example,
https://build.webkit.org/builders/Apple-Catalina-Debug-WK1-Tests/builds/70/steps/layout-test/logs/stdio

testRunner.accummulateLogsForChannel was added by Bug 157274.
Comment 1 Fujii Hironori 2019-10-15 21:08:08 PDT 
It is used in the following tests:

grep -re accummulateLogsForChannel *
storage/indexeddb/modern/resources/256-open-databases.js\04:    testRunner.accummulateLogsForChannel("IndexedDB");
storage/indexeddb/modern/resources/abort-requests-cancelled.js\04:    testRunner.accummulateLogsForChannel("IndexedDB");
storage/indexeddb/modern/resources/autoincrement-abort.js\07:    testRunner.accummulateLogsForChannel("IndexedDB");
storage/indexeddb/resources/intversion-open-in-upgradeneeded.js\09:    testRunner.accummulateLogsForChannel("IndexedDB");
storage/indexeddb/resources/odd-strings.js\09:    testRunner.accummulateLogsForChannel("IndexedDB");
Comment 2 Fujii Hironori 2019-10-15 21:15:41 PDT 
Created attachment 381051 [details]
Patch
Comment 3 WebKit Commit Bot 2019-10-16 11:15:08 PDT 
Comment on attachment 381051 [details]
Patch

Clearing flags on attachment: 381051

Committed r251193: <https://trac.webkit.org/changeset/251193>
Comment 4 WebKit Commit Bot 2019-10-16 11:15:10 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-10-16 11:16:18 PDT 
<rdar://problem/56339259>