Bug 203023 – Make requestIdleCallback suspendable

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

Make it possible to put a document with pending requestIdleCallbacks into page cache.

[Ryosuke Niwa]

Created attachment 381050 [details]
WIP

[Ryosuke Niwa]

Created attachment 381061 [details]
Adds support

[Ryosuke Niwa]

Created attachment 381150 [details]
Fixed tests

[Ryosuke Niwa]

Created attachment 381151 [details]
Updated for trunk

[EWS Watchlist]

Comment on attachment 381151 [details]
Updated for trunk

Attachment 381151 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13141881

New failing tests:
requestidlecallback/requestidlecallback-in-page-cache.html

[EWS Watchlist]

Created attachment 381156 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Ryosuke Niwa]

Created attachment 381159 [details]
Fixed the test for ToT

[Chris Dumez]

Comment on attachment 381159 [details]
Fixed the test for ToT

View in context: https://bugs.webkit.org/attachment.cgi?id=381159&action=review

r=me

> Source/WebCore/dom/WindowEventLoop.cpp:84
> +    for (auto& task : m_tasks)

remainingTasks.appendVector(m_tasks); would be more concise and likely more efficient.

> Source/WebCore/dom/WindowEventLoop.h:69
> +    Vector<Task> m_suspendedTasks;

This appears to be unused?

[Ryosuke Niwa]

(In reply to Chris Dumez from comment #8)
> Comment on attachment 381159 [details]
> Fixed the test for ToT
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=381159&action=review
> 
> r=me
> 
> > Source/WebCore/dom/WindowEventLoop.cpp:84
> > +    for (auto& task : m_tasks)
> 
> remainingTasks.appendVector(m_tasks); would be more concise and likely more
> efficient.

The problem is that remainingTasks.appendVector doesn't support movable but non-copyable objects. I'm gonna keep it as is but we should probably add a new variant of appendVector which supports move constructor.

> > Source/WebCore/dom/WindowEventLoop.h:69
> > +    Vector<Task> m_suspendedTasks;
> 
> This appears to be unused?

Oh oops, removed.

[Ryosuke Niwa]

Committed r251258: <https://trac.webkit.org/changeset/251258>

[Radar WebKit Bug Importer]

<rdar://problem/56385403>