Bug 203022 - Fix the internal macOS build after r251171
Summary: Fix the internal macOS build after r251171
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-15 20:21 PDT by Wenson Hsieh
Modified: 2019-10-15 22:40 PDT (History)
6 users (show)

See Also:

Attachments
Patch (12.57 KB, patch)
2019-10-15 21:22 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
For EWS (12.46 KB, patch)
2019-10-15 21:44 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-10-15 20:21:42 PDT 
r251171 breaks the internal macOS Catalina build.
Comment 1 Wenson Hsieh 2019-10-15 21:04:16 PDT 
It would seem that <HIServices/AccessibilityPriv.h> is exposed via the ApplicationServices framework. Though I might be missing something here (I probably am :/)
Comment 2 Wenson Hsieh 2019-10-15 21:22:51 PDT 
Created attachment 381052 [details]
Patch
Comment 3 mitz 2019-10-15 21:34:05 PDT 
Comment on attachment 381052 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381052&action=review

> Source/WebKit/Platform/spi/mac/ApplicationServicesSPI.h:33
> +#pragma clang diagnostic ignored "-Wundef"

Is this still needed? The location ApplicationServicesPriv.h is being imported from should be recognized as a system header location and therefore exempt from warnings.

> Source/WebKit/Platform/spi/mac/ApplicationServicesSPI.h:59
> +extern AXClientType _AXGetClientForCurrentRequestUntrusted(void);

I know that this is just being moved around, but normally we keep function declarations outside the #if/#else/#endif since it’s harmless to repeat a declaration and it gives us extra protection in case the declaration in the private header changes.
Comment 4 Wenson Hsieh 2019-10-15 21:41:23 PDT 
Comment on attachment 381052 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381052&action=review

Thanks for the review!

>> Source/WebKit/Platform/spi/mac/ApplicationServicesSPI.h:33
>> +#pragma clang diagnostic ignored "-Wundef"
> 
> Is this still needed? The location ApplicationServicesPriv.h is being imported from should be recognized as a system header location and therefore exempt from warnings.

Fixed!

>> Source/WebKit/Platform/spi/mac/ApplicationServicesSPI.h:59
>> +extern AXClientType _AXGetClientForCurrentRequestUntrusted(void);
> 
> I know that this is just being moved around, but normally we keep function declarations outside the #if/#else/#endif since it’s harmless to repeat a declaration and it gives us extra protection in case the declaration in the private header changes.

Sounds good — moved out of the #if/#else/#endif.
Comment 5 Wenson Hsieh 2019-10-15 21:44:33 PDT 
Created attachment 381053 [details]
For EWS
Comment 6 WebKit Commit Bot 2019-10-15 22:39:21 PDT 
Comment on attachment 381053 [details]
For EWS

Clearing flags on attachment: 381053

Committed r251179: <https://trac.webkit.org/changeset/251179>
Comment 7 WebKit Commit Bot 2019-10-15 22:39:23 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-10-15 22:40:16 PDT 
<rdar://problem/56320543>