WKWebsiteDataStoreStatisticsResetToConsistentState() should call store.setUseITPDatabase(false)

[Kate Cheney]

WKWebsiteDataStoreStatisticsResetToConsistentState() should call store.setUseITPDatabase(false) between tests to keep consistent state

[Kate Cheney]

<rdar://problem/56314484>

[Kate Cheney]

Created attachment 381093 [details]
Patch

[Chris Dumez]

Comment on attachment 381093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381093&action=review

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:1793
> +void TestRunner::setUseITPDatabase(bool value, JSValueRef completionHandler)

This does not need a completion handler. It can be synchronous from TestRunner's point of view. Layout test should not have to deal with this being async.

> Tools/WebKitTestRunner/TestController.cpp:3388
> +    m_currentInvocation->didSetUseITPDatabase();

No need. This is called on a sync IPC from the WebContent process so once the WKBundlePostSynchronousMessage() returns, the caller can assume the operation has finished, given the runUntil() call above.

[Kate Cheney]

Created attachment 381098 [details]
Patch

[Kate Cheney]

Thanks Chris! waiting to make sure all tests pass on the bots before asking for cq+

[WebKit Commit Bot]

Comment on attachment 381098 [details]
Patch

Clearing flags on attachment: 381098

Committed r251212: <https://trac.webkit.org/changeset/251212>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56348972>