Bug 20302 – Wrong signbit implementation for solaris platform

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Alexey Ushakov]

Solaris platform has incomplete implementation for signbit finction in JavaScriptCore/wtf/MathExtras.h.

Here is correct implementation of this function:

inline bool signbit(double num) { return copysign(1.0, num) < 0; }

[Alexey Ushakov]

Created attachment 22680 [details]
signbit patch for solaris platform

[Ben Taylor]

Created attachment 86785 [details]
Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler

Add a correct patch that includes a ChangeLog and proper patch using the webkit tools. This was done against webkit head and compiles correctly on Solaris 10/SS12 against qt-4.7.1

[Darin Adler]

Comment on attachment 86785 [details]
Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler

View in context: https://bugs.webkit.org/attachment.cgi?id=86785&action=review

> Source/JavaScriptCore/wtf/MathExtras.h:93
> -inline bool signbit(double x) { return x < 0.0; } // FIXME: Wrong for negative 0.
> +inline bool signbit(double num) { return copysign(1.0, num) < 0; }

I guess you copied the version from MSVC, which is why the variable name is now num. I would prefer that this file use "x" more consistently or use a word like "number" rather than "num".

[Ben Taylor]

Created attachment 86789 [details]
Updated patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler, fixed variable "num" to be "x"

Updated patch per request

[WebKit Commit Bot]

Comment on attachment 86789 [details]
Updated patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler, fixed variable "num" to be "x"

Clearing flags on attachment: 86789

Committed r81882: <http://trac.webkit.org/changeset/81882>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/81882 might have broken Qt Linux Release
The following tests are not passing:
editing/pasteboard/5065605.html
editing/pasteboard/display-block-on-spans.html
editing/pasteboard/paste-text-011.html
editing/pasteboard/paste-text-at-tabspan-002.html