Bug 203014 - [iOS] Maintain the last Back/Forward cache entry when the application gets suspended
Summary: [iOS] Maintain the last Back/Forward cache entry when the application gets su...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 202293
  Show dependency treegraph
 
Reported: 2019-10-15 16:45 PDT by Chris Dumez
Modified: 2019-10-15 18:50 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.31 KB, patch)
2019-10-15 16:52 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-10-15 16:45:13 PDT
Maintain the last Back/Forward cache entry when the application gets suspended. Homing out of MobileSafari currently kills all back/forward cache entries so no more fast back when coming back to MobileSafari.
Comment 1 Chris Dumez 2019-10-15 16:52:22 PDT
Created attachment 381038 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-10-15 16:52:43 PDT
<rdar://problem/56313898>
Comment 3 Geoffrey Garen 2019-10-15 17:06:47 PDT
Comment on attachment 381038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381038&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:593
> +    if (m_prewarmedProcess)
> +        m_prewarmedProcess->shutDown();

Do we need to kill the prewarmed process? Jetsam can always kill it if needed. And it's a bummer to make the next link navigation slow in cases where you're multitasking.

I guess this was our existing behavior, so my question may be out of scope of this patch.

The same question applies to the process cache too.
Comment 4 Chris Dumez 2019-10-15 18:25:15 PDT
(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 381038 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=381038&action=review
> 
> r=me
> 
> > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:593
> > +    if (m_prewarmedProcess)
> > +        m_prewarmedProcess->shutDown();
> 
> Do we need to kill the prewarmed process? Jetsam can always kill it if
> needed. And it's a bummer to make the next link navigation slow in cases
> where you're multitasking.
> 
> I guess this was our existing behavior, so my question may be out of scope
> of this patch.

Yes, this is not new behavior in this patch. I can follow-up and change this.

> 
> The same question applies to the process cache too.

Does not really matter since the process cache is currently disabled on iOS.
Comment 5 WebKit Commit Bot 2019-10-15 18:50:00 PDT
Comment on attachment 381038 [details]
Patch

Clearing flags on attachment: 381038

Committed r251174: <https://trac.webkit.org/changeset/251174>
Comment 6 WebKit Commit Bot 2019-10-15 18:50:01 PDT
All reviewed patches have been landed.  Closing bug.