Bug 203014 – [iOS] Maintain the last Back/Forward cache entry when the application gets suspended

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Maintain the last Back/Forward cache entry when the application gets suspended. Homing out of MobileSafari currently kills all back/forward cache entries so no more fast back when coming back to MobileSafari.

[Chris Dumez]

Created attachment 381038 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/56313898>

[Geoffrey Garen]

Comment on attachment 381038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381038&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:593
> +    if (m_prewarmedProcess)
> +        m_prewarmedProcess->shutDown();

Do we need to kill the prewarmed process? Jetsam can always kill it if needed. And it's a bummer to make the next link navigation slow in cases where you're multitasking.

I guess this was our existing behavior, so my question may be out of scope of this patch.

The same question applies to the process cache too.

[Chris Dumez]

(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 381038 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=381038&action=review
> 
> r=me
> 
> > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:593
> > +    if (m_prewarmedProcess)
> > +        m_prewarmedProcess->shutDown();
> 
> Do we need to kill the prewarmed process? Jetsam can always kill it if
> needed. And it's a bummer to make the next link navigation slow in cases
> where you're multitasking.
> 
> I guess this was our existing behavior, so my question may be out of scope
> of this patch.

Yes, this is not new behavior in this patch. I can follow-up and change this.

> 
> The same question applies to the process cache too.

Does not really matter since the process cache is currently disabled on iOS.

[WebKit Commit Bot]

Comment on attachment 381038 [details]
Patch

Clearing flags on attachment: 381038

Committed r251174: <https://trac.webkit.org/changeset/251174>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.