Bug 203007 – Web Inspector: Debugger: prevent source mapped resources from being blackboxed

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Since source mapped resources are entirely a frontend concept, it doesn't make sense to allow them to be blackboxed.  We shouldn't show any <(*)> eye for them.

[Devin Rousso]

Created attachment 381025 [details]
Patch

[Matt Baker]

Comment on attachment 381025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381025&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/SourceMapResource.js:79
> +        return false;

Style: simple getters should be one line.

[Devin Rousso]

Comment on attachment 381025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381025&action=review

>> Source/WebInspectorUI/UserInterface/Models/SourceMapResource.js:79
>> +        return false;
> 
> Style: simple getters should be one line.

Although the code for this is very basic, I wouldn't consider this to be "simple", as I find it's harder to immediately grok when it's on one line.

```
    get supportsScriptBlackboxing() { return false; }
```
vs
```
    get supportsScriptBlackboxing()
    {
        return false;
    }
```

In the first case, I have to find where the `() {` are to distinguish between the function name and it's body, whereas in the second case it's immediately obvious since they're on different lines.

In my mind, a "simple" getter is one where the function name is the exact same as the member variable being used in the function's body.
```
    get element() { return this._element; }
    set element(x) { this._element = x; }
```

We're not very consistent for this in Web Inspector code, so I'm going to land this as-is until there's a discussion/consensus.

[WebKit Commit Bot]

Comment on attachment 381025 [details]
Patch

Clearing flags on attachment: 381025

Committed r251170: <https://trac.webkit.org/changeset/251170>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56314273>