[Tools] Add a driver for cog for benchmark_runner.py

[Pablo Saavedra]

SSIA

[Pablo Saavedra]

Created attachment 381000 [details]
patch

[Jonathan Bedard]

Comment on attachment 381000 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381000&action=review

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_cog_driver.py:49
> +        super(CogBrowserDriver, self).launch_url(url, options,

Should be super(CogFdoBrowserDriver, ...)

[Pablo Saavedra]

It sE1003(In reply to Jonathan Bedard from comment #2)
> Comment on attachment 381000 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=381000&action=review
> 
> > Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_cog_driver.py:49
> > +        super(CogBrowserDriver, self).launch_url(url, options,
> 
> Should be super(CogFdoBrowserDriver, ...)


pylint is blaming against the usage of super() in the launch_url() function. I explitelly invoked the grandfathers method class to bypass the logic introduced in  the CogBrowserDriver class which is the parent class.


Anyway, for the sake of simplicity, I will rewrite the patch to inherit directly from the LinuxBrowserDriver. This introduces a couple of lines more but still is a simply code and probably less prone to future mistakes.

[Pablo Saavedra]

Created attachment 381060 [details]
patch

[Pablo Saavedra]

Created attachment 381066 [details]
patch

[WebKit Commit Bot]

Comment on attachment 381066 [details]
patch

Clearing flags on attachment: 381066

Committed r251191: <https://trac.webkit.org/changeset/251191>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56337507>