Bug 202991 – [LFC][TFC] Add support for colgroup/col

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

<col>'s width attribute can drive the preferred width of the table column (trac uses this)

[Radar WebKit Bug Importer]

<rdar://problem/56294715>

[zalan]

Created attachment 380994 [details]
Patch

[Antti Koivisto]

Comment on attachment 380994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380994&action=review

> Source/WebCore/layout/tableformatting/TableFormattingContext.cpp:182
> +    const Box* colgroup = nullptr;
> +    // Table caption is an optional element; if used, it is always the first child of a <table>.
> +    if (firstChild->isTableCaption())
> +        tableCaption = firstChild;
> +    // The <colgroup> must appear after any optional <caption> element but before any <thead>, <th>, <tbody>, <tfoot> and <tr> element.
> +    auto* colgroupCandidate = firstChild;
> +    if (tableCaption)
> +        colgroupCandidate = tableCaption->nextSibling();
> +    if (colgroupCandidate->isTableColumnGroup())
> +        colgroup = colgroupCandidate;

You might want to factor finding captions and colgroups into functions.

[zalan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 380994 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=380994&action=review
> 
> > Source/WebCore/layout/tableformatting/TableFormattingContext.cpp:182
> > +    const Box* colgroup = nullptr;
> > +    // Table caption is an optional element; if used, it is always the first child of a <table>.
> > +    if (firstChild->isTableCaption())
> > +        tableCaption = firstChild;
> > +    // The <colgroup> must appear after any optional <caption> element but before any <thead>, <th>, <tbody>, <tfoot> and <tr> element.
> > +    auto* colgroupCandidate = firstChild;
> > +    if (tableCaption)
> > +        colgroupCandidate = tableCaption->nextSibling();
> > +    if (colgroupCandidate->isTableColumnGroup())
> > +        colgroup = colgroupCandidate;
> 
> You might want to factor finding captions and colgroups into functions.

good idea

[zalan]

(In reply to zalan from comment #4)
> (In reply to Antti Koivisto from comment #3)
> > Comment on attachment 380994 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=380994&action=review
> > 
> > > Source/WebCore/layout/tableformatting/TableFormattingContext.cpp:182
> > > +    const Box* colgroup = nullptr;
> > > +    // Table caption is an optional element; if used, it is always the first child of a <table>.
> > > +    if (firstChild->isTableCaption())
> > > +        tableCaption = firstChild;
> > > +    // The <colgroup> must appear after any optional <caption> element but before any <thead>, <th>, <tbody>, <tfoot> and <tr> element.
> > > +    auto* colgroupCandidate = firstChild;
> > > +    if (tableCaption)
> > > +        colgroupCandidate = tableCaption->nextSibling();
> > > +    if (colgroupCandidate->isTableColumnGroup())
> > > +        colgroup = colgroupCandidate;
> > 
> > You might want to factor finding captions and colgroups into functions.
> 
> good idea
Though, as a second thought, this is the only time when we need traverse the layout tree in the table code (layout uses the grid and not the tree).

[Antti Koivisto]

Comment on attachment 380994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380994&action=review

>>>> Source/WebCore/layout/tableformatting/TableFormattingContext.cpp:182
>>>> +        colgroup = colgroupCandidate;
>>> 
>>> You might want to factor finding captions and colgroups into functions.
>> 
>> good idea
> 
> Though, as a second thought, this is the only time when we need traverse the layout tree in the table code (layout uses the grid and not the tree).

Lambdas!

[zalan]

(In reply to Antti Koivisto from comment #6)
> Comment on attachment 380994 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=380994&action=review
> 
> >>>> Source/WebCore/layout/tableformatting/TableFormattingContext.cpp:182
> >>>> +        colgroup = colgroupCandidate;
> >>> 
> >>> You might want to factor finding captions and colgroups into functions.
> >> 
> >> good idea
> > 
> > Though, as a second thought, this is the only time when we need traverse the layout tree in the table code (layout uses the grid and not the tree).
> 
> Lambdas!
I love lambdas!

[WebKit Commit Bot]

Comment on attachment 380994 [details]
Patch

Clearing flags on attachment: 380994

Committed r251147: <https://trac.webkit.org/changeset/251147>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.