Bug 202989 - Stop using inheritance for WebBackForwardCacheEntry
Summary: Stop using inheritance for WebBackForwardCacheEntry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 202293
  Show dependency tree / graph
 
Reported: 2019-10-15 08:48 PDT by Chris Dumez
Modified: 2019-10-15 14:31 PDT (History)
7 users (show)

See Also:

Attachments
Patch (13.75 KB, patch)
2019-10-15 08:55 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (14.32 KB, patch)
2019-10-15 09:09 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (14.34 KB, patch)
2019-10-15 09:19 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (15.44 KB, patch)
2019-10-15 09:28 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-10-15 08:48:05 PDT 
Stop using inheritance for WebBackForwardCacheEntry. This simplifies the code a bit.
Comment 1 Chris Dumez 2019-10-15 08:55:03 PDT 
Created attachment 380988 [details]
Patch
Comment 2 Chris Dumez 2019-10-15 09:09:06 PDT 
Created attachment 380989 [details]
Patch
Comment 3 Chris Dumez 2019-10-15 09:19:20 PDT 
Created attachment 380991 [details]
Patch
Comment 4 Chris Dumez 2019-10-15 09:28:21 PDT 
Created attachment 380992 [details]
Patch
Comment 5 Chris Dumez 2019-10-15 09:31:38 PDT 
Fighting with unified build and GTK/WPE...
Comment 6 WebKit Commit Bot 2019-10-15 09:56:20 PDT 
Comment on attachment 380992 [details]
Patch

Clearing flags on attachment: 380992

Committed r251142: <https://trac.webkit.org/changeset/251142>
Comment 7 WebKit Commit Bot 2019-10-15 09:56:22 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Antti Koivisto 2019-10-15 11:57:43 PDT 
Comment on attachment 380992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380992&action=review

Much better!

> Source/WebKit/UIProcess/WebBackForwardCacheEntry.h:55
> +    WebCore::ProcessIdentifier m_processIdentifier;
> +    WebCore::BackForwardItemIdentifier m_backForwardItemID;
> +    std::unique_ptr<SuspendedPageProxy> m_suspendedPage;

If you want the get fancy you can always use Variant<> as a replacement for subclassing (maybe overkill here).
Comment 9 Ling Ho 2019-10-15 14:31:16 PDT 
<rdar://problem/56295952>
Comment 10 Radar WebKit Bug Importer 2019-10-15 14:31:30 PDT 
<rdar://problem/56308355>