Bug 202986 - Interpreter: Don't assert that reference is nonnull
Summary: Interpreter: Don't assert that reference is nonnull
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Trivial
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-15 06:39 PDT by Angelos Oikonomopoulos
Modified: 2019-10-15 14:28 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.33 KB, patch)
2019-10-15 06:46 PDT, Angelos Oikonomopoulos 		no flags Details | Formatted Diff | Diff
Patch (1.47 KB, patch)
2019-10-15 08:15 PDT, Angelos Oikonomopoulos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Angelos Oikonomopoulos 2019-10-15 06:39:46 PDT 
Interpreter: Don't assert that reference is nonnull
Comment 1 Angelos Oikonomopoulos 2019-10-15 06:46:37 PDT 
Created attachment 380982 [details]
Patch
Comment 2 Mark Lam 2019-10-15 07:46:29 PDT 
Comment on attachment 380982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380982&action=review

Did you mean to get a review for this patch?  If so, you should flag it as r? (see the r: box).

> Source/JavaScriptCore/ChangeLog:9
> +        Interpreter: Don't assert that reference is nonnull
> +        https://bugs.webkit.org/show_bug.cgi?id=202986
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * interpreter/FrameTracers.h:
> +        (JSC::NativeCallFrameTracer::NativeCallFrameTracer):

Please add a comment here to explain your change.
Comment 3 Angelos Oikonomopoulos 2019-10-15 08:15:39 PDT 
Created attachment 380986 [details]
Patch
Comment 4 Angelos Oikonomopoulos 2019-10-15 08:17:37 PDT 
Oops. Should be better now.
Comment 5 Keith Miller 2019-10-15 08:48:29 PDT 
Comment on attachment 380986 [details]
Patch

r=me.
Comment 6 WebKit Commit Bot 2019-10-15 09:35:12 PDT 
Comment on attachment 380986 [details]
Patch

Clearing flags on attachment: 380986

Committed r251139: <https://trac.webkit.org/changeset/251139>
Comment 7 WebKit Commit Bot 2019-10-15 09:35:15 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Ling Ho 2019-10-15 14:28:26 PDT 
<rdar://problem/56294960>
Comment 9 Radar WebKit Bug Importer 2019-10-15 14:28:35 PDT 
<rdar://problem/56308232>