RESOLVED INVALID 202985
REGRESSION (iOS 13): Invalid pictureInPictureEnabled API result
https://bugs.webkit.org/show_bug.cgi?id=202985
Summary REGRESSION (iOS 13): Invalid pictureInPictureEnabled API result
Oren Me
Reported 2019-10-15 06:34:50 PDT
Safari on iOS13 returns document.pictureInPictureEnabled as true, while it didn't on iOS12. This breaks previous implementations where standard detection on Chrome uses document.pictureInPictureEnabled to detect support and iOS uses typeof video.webkitSupportsPresentationMode === 'function' && video.webkitSupportsPresentationMode('picture-in-picture') now we need to do also user agent detection to exclude the document.pictureInPictureEnabled from iOS. Is this change related to the work done for https://bugs.webkit.org/show_bug.cgi?id=201024?
Attachments
Alexey Proskuryakov
Comment 1 2019-10-15 09:31:03 PDT
I cannot reproduce this - I get undefined on iPhone, iPad, and Mac. Also, there are no instances of "pictureInPictureEnabled" in WebKit code base. Are you sure that it's not coming from some polyfill? If you can still reproduce, could you please attach a complete test case?
Oren Me
Comment 2 2019-10-15 10:58:55 PDT
Alexey, you are correct, didn't even occur to me to check, but apparently Shaka player added a polyfill to patch over PiP for Safari and it adds document.pictureInPictureEnabled=true Thanks for the quick response.
Note You need to log in before you can comment on or make changes to this bug.