Bug 202980 – [GTK][WPE] IconDatabase is not thread safe yet

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

Current implementation is safer, but we still need to protect members used by both threads.

[Carlos Garcia Campos]

Created attachment 380970 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Adrian Perez]

Comment on attachment 380970 [details]
Patch

Patch LGTM. Given that all the uses of the database (“m_db” member)
are done in the work queue thread, maybe it would be a good thing
to add “ASSERT(!isMainThread())” at the top of helper functions
like “IconDatabase::createTablesIfNeeded()” to make it clearer that
they are not intended to be used directly from the main thread, WDYT?

[Carlos Garcia Campos]

(In reply to Adrian Perez from comment #3)
> Comment on attachment 380970 [details]
> Patch
> 
> Patch LGTM. Given that all the uses of the database (“m_db” member)
> are done in the work queue thread, maybe it would be a good thing
> to add “ASSERT(!isMainThread())” at the top of helper functions
> like “IconDatabase::createTablesIfNeeded()” to make it clearer that
> they are not intended to be used directly from the main thread, WDYT?

Sure, I can add it.

[Carlos Garcia Campos]

Committed r251362: <https://trac.webkit.org/changeset/251362>