Bug 202979 – Remove duplicate MathML tests

• Status: RESOLVED
• Resolution: FIXED
• Component: MathML

[Rob Buis]

Some WebKit MathML tests got imported into WPT and are now just duplicates.

[Rob Buis]

Created attachment 380969 [details]
Patch

[Frédéric Wang (:fredw)]

Comment on attachment 380969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380969&action=review

> LayoutTests/ChangeLog:9
> +        presentation-markup/spaces/mspace-children.html.

Strictly speaking, the WPT test checks that the children are not visible while the WebKit test checks that no renderers are created at all, so the latter is a bit stronger.

[Rob Buis]

Created attachment 380976 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 380976 [details]
Patch

Clearing flags on attachment: 380976

Committed r251130: <https://trac.webkit.org/changeset/251130>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Rob Buis]

Reopening to attach new patch.

[Rob Buis]

Created attachment 380985 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/56291547>

[Radar WebKit Bug Importer]

<rdar://problem/56291548>

[WebKit Commit Bot]

Comment on attachment 380985 [details]
Patch

Clearing flags on attachment: 380985

Committed r251187: <https://trac.webkit.org/changeset/251187>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Truitt Savell]

It looks like in https://trac.webkit.org/changeset/251187/webkit

you removed imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-form-fallback-expected.html

but not the test itself which is now showing missing results in history: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fmathml%2Fpresentation-markup%2Foperators%2Fmo-form-fallback.html

Can you resolve this?

[Rob Buis]

(In reply to Truitt Savell from comment #12)
> It looks like in https://trac.webkit.org/changeset/251187/webkit
> 
> you removed
> imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-form-
> fallback-expected.html
> 
> but not the test itself which is now showing missing results in history:
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-
> tests%2Fmathml%2Fpresentation-markup%2Foperators%2Fmo-form-fallback.html
> 
> Can you resolve this?

Sure, will have a look.

[Rob Buis]

Reopening to attach new patch.

[Rob Buis]

Created attachment 381202 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 381202 [details]
Patch

Clearing flags on attachment: 381202

Committed r251253: <https://trac.webkit.org/changeset/251253>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Rob Buis]

Reopening to attach new patch.

[Rob Buis]

Created attachment 387776 [details]
Patch

[Rob Buis]

I forgot about the https://bugs.webkit.org/show_bug.cgi?id=202979#c2 comment.