Bug 202979 - Remove duplicate MathML tests
Summary: Remove duplicate MathML tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-15 01:26 PDT by Rob Buis
Modified: 2020-01-20 01:26 PST (History)
6 users (show)

See Also:


Attachments
Patch (41.83 KB, patch)
2019-10-15 01:34 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (30.91 KB, patch)
2019-10-15 02:44 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (16.90 KB, patch)
2019-10-15 07:41 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (1.65 KB, patch)
2019-10-17 10:41 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (6.58 KB, patch)
2020-01-15 04:17 PST, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2019-10-15 01:26:27 PDT
Some WebKit MathML tests got imported into WPT and are now just duplicates.
Comment 1 Rob Buis 2019-10-15 01:34:24 PDT
Created attachment 380969 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2019-10-15 01:51:36 PDT
Comment on attachment 380969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380969&action=review

> LayoutTests/ChangeLog:9
> +        presentation-markup/spaces/mspace-children.html.

Strictly speaking, the WPT test checks that the children are not visible while the WebKit test checks that no renderers are created at all, so the latter is a bit stronger.
Comment 3 Rob Buis 2019-10-15 02:44:23 PDT
Created attachment 380976 [details]
Patch
Comment 4 WebKit Commit Bot 2019-10-15 03:39:13 PDT
Comment on attachment 380976 [details]
Patch

Clearing flags on attachment: 380976

Committed r251130: <https://trac.webkit.org/changeset/251130>
Comment 5 WebKit Commit Bot 2019-10-15 03:39:15 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Rob Buis 2019-10-15 07:41:29 PDT
Reopening to attach new patch.
Comment 7 Rob Buis 2019-10-15 07:41:32 PDT
Created attachment 380985 [details]
Patch
Comment 8 Radar WebKit Bug Importer 2019-10-15 07:41:45 PDT
<rdar://problem/56291547>
Comment 9 Radar WebKit Bug Importer 2019-10-15 07:41:47 PDT
<rdar://problem/56291548>
Comment 10 WebKit Commit Bot 2019-10-16 07:43:48 PDT
Comment on attachment 380985 [details]
Patch

Clearing flags on attachment: 380985

Committed r251187: <https://trac.webkit.org/changeset/251187>
Comment 11 WebKit Commit Bot 2019-10-16 07:43:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Truitt Savell 2019-10-17 10:14:33 PDT
It looks like in https://trac.webkit.org/changeset/251187/webkit

you removed imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-form-fallback-expected.html

but not the test itself which is now showing missing results in history: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fmathml%2Fpresentation-markup%2Foperators%2Fmo-form-fallback.html

Can you resolve this?
Comment 13 Rob Buis 2019-10-17 10:27:47 PDT
(In reply to Truitt Savell from comment #12)
> It looks like in https://trac.webkit.org/changeset/251187/webkit
> 
> you removed
> imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-form-
> fallback-expected.html
> 
> but not the test itself which is now showing missing results in history:
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-
> tests%2Fmathml%2Fpresentation-markup%2Foperators%2Fmo-form-fallback.html
> 
> Can you resolve this?

Sure, will have a look.
Comment 14 Rob Buis 2019-10-17 10:41:19 PDT
Reopening to attach new patch.
Comment 15 Rob Buis 2019-10-17 10:41:21 PDT
Created attachment 381202 [details]
Patch
Comment 16 WebKit Commit Bot 2019-10-17 12:23:30 PDT
Comment on attachment 381202 [details]
Patch

Clearing flags on attachment: 381202

Committed r251253: <https://trac.webkit.org/changeset/251253>
Comment 17 WebKit Commit Bot 2019-10-17 12:23:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 18 Rob Buis 2020-01-15 04:17:40 PST
Reopening to attach new patch.
Comment 19 Rob Buis 2020-01-15 04:17:43 PST
Created attachment 387776 [details]
Patch
Comment 20 Rob Buis 2020-01-20 01:26:46 PST
I forgot about the https://bugs.webkit.org/show_bug.cgi?id=202979#c2 comment.