Bug 20297 - REGRESSION: Lots of AccessibilityUIElement leaks on the buildbot
Summary: REGRESSION: Lots of AccessibilityUIElement leaks on the buildbot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P1 Normal
Assignee: Nobody
URL: http://build.webkit.org/results/trunk...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2008-08-06 05:14 PDT by Eric Seidel (no email)
Modified: 2008-08-06 14:25 PDT (History)
2 users (show)

See Also:


Attachments
Fix AccessibilityUIElement leaks seen on buildbot (18.00 KB, patch)
2008-08-06 05:14 PDT, Eric Seidel (no email)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2008-08-06 05:14:15 PDT
Lots of AccessibilityUIElement leaks on the buildbot

http://build.webkit.org/results/trunk-mac-intel-debug/4749/DumpRenderTree-leaks.txt

I have a fix.  Which I'll upload shortly.
Comment 1 Eric Seidel (no email) 2008-08-06 05:14:59 PDT
Created attachment 22677 [details]
Fix AccessibilityUIElement leaks seen on buildbot

 WebKitTools/ChangeLog                              |   46 +++++++++++++++
 .../DumpRenderTree/AccessibilityController.h       |    4 +-
 .../DumpRenderTree/AccessibilityUIElement.cpp      |   61 ++++++++------------
 .../DumpRenderTree/AccessibilityUIElement.h        |   11 ++--
 .../mac/AccessibilityControllerMac.mm              |    8 +-
 .../mac/AccessibilityUIElementMac.mm               |   30 ++++++----
 6 files changed, 101 insertions(+), 59 deletions(-)
Comment 2 Eric Seidel (no email) 2008-08-06 05:15:48 PDT
That's right.  18k characters on the money.  That's how I roll.
Comment 3 mitz 2008-08-06 07:32:47 PDT
<rdar://problem/6093153>
Comment 4 Darin Adler 2008-08-06 10:27:11 PDT
Comment on attachment 22677 [details]
Fix AccessibilityUIElement leaks seen on buildbot

Looks fine, r=me
Comment 5 mitz 2008-08-06 14:25:27 PDT
Landed in <http://trac.webkit.org/changeset/35608>.