Add support to TextStream for dumping HashMap<> and HashSet<>

[Simon Fraser (smfr)]

Add support to TextStream for dumping HashMap<> and HashSet<>

[Simon Fraser (smfr)]

Created attachment 380960 [details]
Patch

[Dean Jackson]

Comment on attachment 380960 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380960&action=review

> Source/WTF/wtf/text/TextStream.h:181
> +    if (item)
> +        return ts << item.value();

Shouldn't this make it clear that it was an optional value? e.g. item.value() << "<Opt>" or something?

> Source/WTF/wtf/text/TextStream.h:207
> +    for (const auto& keyValuePair : map) {

Wish there were forEach-like functions on Hash*

[WebKit Commit Bot]

Comment on attachment 380960 [details]
Patch

Clearing flags on attachment: 380960

Committed r251325: <https://trac.webkit.org/changeset/251325>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56436596>