Bug 202961 - REGRESSION(251087): Several API tests are failing
Summary: REGRESSION(251087): Several API tests are failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-14 16:30 PDT by Per Arne Vollan
Modified: 2019-10-15 14:18 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.65 KB, patch)
2019-10-14 16:34 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2019-10-14 16:30:07 PDT 
r251087 introduced assert failures in debug mode:

TestWebKitAPI.WebKit.GetPIDAfterAbortedProcessLaunch
        ASSERTION FAILED: m_connection
        Source/WebKit/UIProcess/AuxiliaryProcessProxy.h(69) : IPC::Connection *WebKit::AuxiliaryProcessProxy::connection() const
        1   0x10eebb759 WTFCrash
        2   0x11c8aaa0b WTFCrashWithInfo(int, char const*, char const*, int)
        3   0x11d16c957 WebKit::AuxiliaryProcessProxy::connection() const
        4   0x11d3c99d6 WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle(WebKit::WebProcessProxy&, WTF::URL const&, WTF::URL const&, WebKit::SandboxExtension::Handle&)
        5   0x11d3cd8e8 WebKit::WebPageProxy::reload(WTF::OptionSet<WebCore::ReloadOption>)
        6   0x11d5fbc8b WKPageReload
        7   0x10d267133 TestWebKitAPI::WebKit_GetPIDAfterAbortedProcessLaunch_Test::TestBody()
Comment 1 Per Arne Vollan 2019-10-14 16:34:58 PDT 
Created attachment 380932 [details]
Patch
Comment 2 Brent Fulgham 2019-10-14 16:44:20 PDT 
Comment on attachment 380932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380932&action=review

r=me

> Source/WebKit/UIProcess/WebPageProxy.cpp:1094
> +    if (process.isLaunching() || process.wasTerminated())

Whoops!
Comment 3 Per Arne Vollan 2019-10-14 16:45:07 PDT 
Comment on attachment 380932 [details]
Patch

Thanks for reviewing!
Comment 4 WebKit Commit Bot 2019-10-14 18:04:07 PDT 
Comment on attachment 380932 [details]
Patch

Clearing flags on attachment: 380932

Committed r251116: <https://trac.webkit.org/changeset/251116>
Comment 5 WebKit Commit Bot 2019-10-14 18:04:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Ling Ho 2019-10-15 14:18:30 PDT 
<rdar://problem/56272662>