Bug 202936 - results.webkit.org: TypeError when evaluating empty commits
Summary: results.webkit.org: TypeError when evaluating empty commits
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zhifei Fang
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-14 10:20 PDT by Jonathan Bedard
Modified: 2019-10-15 15:26 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.71 KB, patch)
2019-10-14 10:59 PDT, Zhifei Fang
no flags Details | Formatted Diff | Diff
Patch (3.89 KB, patch)
2019-10-14 16:32 PDT, Zhifei Fang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-10-14 10:20:08 PDT
If the user requests something in the results database that doesn't have any associated results, we end up raising an exception in the timeline code.
Comment 1 Jonathan Bedard 2019-10-14 10:20:25 PDT
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebKit.DefaultQuota&flavor=wk1 is a good example of this.
Comment 2 Zhifei Fang 2019-10-14 10:59:57 PDT
Created attachment 380896 [details]
Patch
Comment 3 Jonathan Bedard 2019-10-14 11:03:41 PDT
Comment on attachment 380896 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380896&action=review

> Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:751
> +        let currentStartScaleIndex = Math.floor(scrollLeft / scaleWidth);

Why did we move this block of code?
Comment 4 Zhifei Fang 2019-10-14 11:17:15 PDT
Comment on attachment 380896 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380896&action=review

>> Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:751
>> +        let currentStartScaleIndex = Math.floor(scrollLeft / scaleWidth);
> 
> Why did we move this block of code?

This will let us draw an empty line instead of drawing nothing.
Comment 5 Zhifei Fang 2019-10-14 16:32:40 PDT
Created attachment 380931 [details]
Patch
Comment 6 WebKit Commit Bot 2019-10-14 17:48:03 PDT
Comment on attachment 380931 [details]
Patch

Clearing flags on attachment: 380931

Committed r251114: <https://trac.webkit.org/changeset/251114>
Comment 7 WebKit Commit Bot 2019-10-14 17:48:05 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Ling Ho 2019-10-15 15:26:25 PDT
<rdar://problem/56272288>