RESOLVED FIXED 202936
results.webkit.org: TypeError when evaluating empty commits 
https://bugs.webkit.org/show_bug.cgi?id=202936
Summary results.webkit.org: TypeError when evaluating empty commits
Jonathan Bedard
Reported 2019-10-14 10:20:08 PDT
If the user requests something in the results database that doesn't have any associated results, we end up raising an exception in the timeline code.
Attachments
Patch (3.71 KB, patch)
2019-10-14 10:59 PDT, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
Patch (3.89 KB, patch)
2019-10-14 16:32 PDT, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-10-14 10:20:25 PDT
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebKit.DefaultQuota&flavor=wk1 is a good example of this.
Zhifei Fang
Comment 2 2019-10-14 10:59:57 PDT
Created attachment 380896 [details] Patch
Jonathan Bedard
Comment 3 2019-10-14 11:03:41 PDT
Comment on attachment 380896 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380896&action=review > Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:751 > + let currentStartScaleIndex = Math.floor(scrollLeft / scaleWidth); Why did we move this block of code?
Zhifei Fang
Comment 4 2019-10-14 11:17:15 PDT
Comment on attachment 380896 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380896&action=review >> Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:751 >> + let currentStartScaleIndex = Math.floor(scrollLeft / scaleWidth); > > Why did we move this block of code? This will let us draw an empty line instead of drawing nothing.
Zhifei Fang
Comment 5 2019-10-14 16:32:40 PDT
Created attachment 380931 [details] Patch
WebKit Commit Bot
Comment 6 2019-10-14 17:48:03 PDT
Comment on attachment 380931 [details] Patch Clearing flags on attachment: 380931 Committed r251114: <https://trac.webkit.org/changeset/251114>
WebKit Commit Bot
Comment 7 2019-10-14 17:48:05 PDT
All reviewed patches have been landed. Closing bug.
Ling Ho
Comment 8 2019-10-15 15:26:25 PDT
<rdar://problem/56272288>
Note You need to log in before you can comment on or make changes to this bug.