Bug 202924 – [GTK][WPE] WebKitWebContext should identify web views by their WebPageProxy identifier

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

Instead of the WebPage identifier.

[Carlos Garcia Campos]

Created attachment 380877 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Adrian Perez]

Comment on attachment 380877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380877&action=review

I just have a comment suggesting a small improvement to the code that
touches the “webViews” map, which could as well be a follow-up.

Otherwise r=me :)

> Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:1807
> +    context->priv->webViews.set(page.identifier().toUInt64(), webView);

Instead of having the explicit .toUInt64() conversions where the “webViews”
is used, the map could be declared as:

  HashMap<WebPageProxyIdentifier, WebKitWebView*> webViews;

This would make explicit in the data type that the mapping is from page
proxy identifiers to web views, and the compiler would help a little bit
doing type checks. There will be still a couple of (unavoidable) casts
when crossing the public API boundaries, but I think it would make the
code a bit more robust. Could be a follow-up patch :)

[Carlos Garcia Campos]

Committed r251127: <https://trac.webkit.org/changeset/251127>