Bug 202920 - Cull inline culling
Summary: Cull inline culling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 229985 229993
Blocks:
  Show dependency tree / graph
 
Reported: 2019-10-14 02:12 PDT by Antti Koivisto
Modified: 2021-09-09 10:07 PDT (History)
18 users (show)

See Also:

Attachments
wip (37.36 KB, patch)
2019-10-14 02:13 PDT, Antti Koivisto 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews211 for win-future (14.02 MB, application/zip)
2019-10-14 03:38 PDT, EWS Watchlist 		no flags Details
try (783 bytes, patch)
2021-09-07 01:21 PDT, Antti Koivisto 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (41.74 KB, patch)
2021-09-09 07:08 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2019-10-14 02:12:46 PDT 
There is lots of complicated code to implement inline culling optimization which avoid creating lineboxes for inline containers in some situations. It doesn't seem like a meaningful optimization in modern web. Maybe we can remove it?
Comment 1 Antti Koivisto 2019-10-14 02:13:57 PDT 
Created attachment 380862 [details]
wip
Comment 2 EWS Watchlist 2019-10-14 03:38:33 PDT 
Comment on attachment 380862 [details]
wip

Attachment 380862 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13127454

Number of test failures exceeded the failure limit.
Comment 3 EWS Watchlist 2019-10-14 03:38:35 PDT 
Created attachment 380869 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 4 Antti Koivisto 2021-09-07 01:21:59 PDT 
Created attachment 437464 [details]
try
Comment 5 Antti Koivisto 2021-09-09 07:08:32 PDT 
Created attachment 437741 [details]
patch
Comment 6 EWS 2021-09-09 10:06:57 PDT 
Committed r282223 (241510@main): <https://commits.webkit.org/241510@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437741 [details].
Comment 7 Radar WebKit Bug Importer 2021-09-09 10:07:30 PDT 
<rdar://problem/82930911>