Bug 202918 - Unify sources for bindings more densely
Summary: Unify sources for bindings more densely
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-13 22:53 PDT by Tim Horton
Modified: 2019-10-15 14:22 PDT (History)
8 users (show)

See Also:

Attachments
Patch (8.06 KB, patch)
2019-10-13 22:56 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (9.91 KB, patch)
2019-10-13 23:49 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (9.96 KB, patch)
2019-10-14 20:42 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-10-13 22:53:21 PDT 
Unify sources for bindings more densely
Comment 1 Tim Horton 2019-10-13 22:56:17 PDT 
Created attachment 380856 [details]
Patch
Comment 2 Tim Horton 2019-10-13 22:57:08 PDT 
I'm going to fiddle some more with the constant, because I think we can even halve it and still get nearly the same speedup (which I don't totally understand, but seems to be the case). But feel free to review the rest of the patch besides that.
Comment 3 Tim Horton 2019-10-13 23:49:51 PDT 
Created attachment 380858 [details]
Patch
Comment 4 Tim Horton 2019-10-14 10:17:17 PDT 
Comment on attachment 380858 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380858&action=review

> Source/WTF/Scripts/generate-unified-source-bundles.rb:263
> +        print("THORTON: #{bundleFileName()} #{bundlePrefix} #{sourceFile}\n")

Whoops
Comment 5 Tim Horton 2019-10-14 20:42:56 PDT 
Created attachment 380955 [details]
Patch
Comment 6 WebKit Commit Bot 2019-10-14 22:53:24 PDT 
Comment on attachment 380955 [details]
Patch

Clearing flags on attachment: 380955

Committed r251123: <https://trac.webkit.org/changeset/251123>
Comment 7 WebKit Commit Bot 2019-10-14 22:53:26 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Ling Ho 2019-10-15 14:22:30 PDT 
<rdar://problem/56280139>