Bug 202892 - [JSC] Make ConcurrentJSLock Lock even if ENABLE_CONCURRENT_JS=OFF
Summary: [JSC] Make ConcurrentJSLock Lock even if ENABLE_CONCURRENT_JS=OFF
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
: 200983 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-10-13 05:18 PDT by Yusuke Suzuki
Modified: 2019-12-18 18:19 PST (History)
12 users (show)

See Also:

Attachments
Patch (5.50 KB, patch)
2019-10-18 15:22 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-10-13 05:18:05 PDT 
We are not respecting ConcurrentJS status when enabling ConcurrentGC. And concurrent GC sometimes use ConcurrentJSLock to get lock.
We should just make ConcurrentJSLock as Lock.
Comment 1 Yusuke Suzuki 2019-10-18 15:22:20 PDT 
Created attachment 381338 [details]
Patch
Comment 2 Mark Lam 2019-10-18 15:28:02 PDT 
Comment on attachment 381338 [details]
Patch

r=me
Comment 3 Yusuke Suzuki 2019-10-18 16:32:09 PDT 
Committed r251307: <https://trac.webkit.org/changeset/251307>
Comment 4 Radar WebKit Bug Importer 2019-10-18 16:33:17 PDT 
<rdar://problem/56424123>
Comment 5 Yusuke Suzuki 2019-12-18 18:19:28 PST 
*** Bug 200983 has been marked as a duplicate of this bug. ***