Bug 20289 - [qt] screenDepthPerComponent returns the wrong value
: [qt] screenDepthPerComponent returns the wrong value
Status: RESOLVED FIXED
: WebKit
Platform
: 528+ (Nightly build)
: All All
: P5 Minor
Assigned To:
:
: EasyFix, Qt
:
:
  Show dependency treegraph
 
Reported: 2008-08-05 12:46 PST by
Modified: 2010-11-07 07:26 PST (History)


Attachments
Patch (2.07 KB, patch)
2010-11-07 05:34 PST, Robert Hogan
no flags Review Patch | Details | Formatted Diff | Diff
Patch (5.27 KB, patch)
2010-11-07 06:41 PST, Robert Hogan
no flags Review Patch | Details | Formatted Diff | Diff
Patch (5.21 KB, patch)
2010-11-07 07:10 PST, Robert Hogan
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2008-08-05 12:46:55 PST
Reading the code in other ports and from its name it seems that screenDepthPerComponent should return the number of pixels for each colour (for instance 8 if the screen depth is 24), but in the qt port it seems to just return the screen depth (24 in the example).
------- Comment #1 From 2010-03-10 03:23:47 PST -------
http://www.w3.org/TR/css3-mediaqueries/#color
------- Comment #2 From 2010-11-07 05:34:00 PST -------
Created an attachment (id=73194) [details]
Patch
------- Comment #3 From 2010-11-07 05:40:58 PST -------
(From update of attachment 73194 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=73194&action=review

> WebCore/ChangeLog:10
> +        No layout tests possible for this I think.

On the contrary! :-)
http://www.w3.org/TR/css3-mediaqueries/#color
------- Comment #4 From 2010-11-07 06:41:38 PST -------
Created an attachment (id=73195) [details]
Patch
------- Comment #5 From 2010-11-07 07:04:56 PST -------
(From update of attachment 73195 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=73195&action=review

LGTM.

> WebCore/ChangeLog:14
> +        Need a short description and bug URL (OOPS!)

Oops, indeed. Remove this when landing.
------- Comment #6 From 2010-11-07 07:10:01 PST -------
Created an attachment (id=73196) [details]
Patch
------- Comment #7 From 2010-11-07 07:26:03 PST -------
(From update of attachment 73196 [details])
Clearing flags on attachment: 73196

Committed r71483: <http://trac.webkit.org/changeset/71483>
------- Comment #8 From 2010-11-07 07:26:09 PST -------
All reviewed patches have been landed.  Closing bug.