Bug 202870 – REGRESSION (r244239) Layout Test fast/canvas/canvas-too-large-to-draw.html is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dean Jackson]

REGRESSION (r244239) Layout Test fast/canvas/canvas-too-large-to-draw.html is failing

[Dean Jackson]

rdar://51862629

[Dean Jackson]

Created attachment 380802 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 380802 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380802&action=review

> Source/WebCore/html/HTMLCanvasElement.h:155
> +    WEBCORE_EXPORT static void setMaxPixelMemoryForTesting(unsigned);

Maybe use a size_t here?

[Dean Jackson]

Committed r251032: <https://trac.webkit.org/changeset/251032>

[Truitt Savell]

It looks like the changes in this patch https://trac.webkit.org/changeset/251032/webkit

broke 2 tests and did not fix fast/canvas/canvas-too-large-to-draw.html

fast/canvas/canvas-transform-identity.html 
fast/canvas/canvas-transform-infinity.html

These all appear to be due to extra console messages.

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fcanvas%2Fcanvas-too-large-to-draw.html%20fast%2Fcanvas%2Fcanvas-transform-identity.html%20fast%2Fcanvas%2Fcanvas-transform-infinity.html

Diffs:
https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r251071%20(7363)/fast/canvas/canvas-too-large-to-draw-diff.txt
https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r251071%20(7363)/fast/canvas/canvas-transform-identity-diff.txt
https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r251071%20(7363)/fast/canvas/canvas-transform-infinity-diff.txt

[Dean Jackson]

Tests fixed in r251094