Add [ActiveDOMObject] to IDLs of ActiveDOMObjects.
Created attachment 380801 [details] Patch
Comment on attachment 380801 [details] Patch Can we also add a static_assert to make sure whatever object which is not marked as ActiveDOMObject doesn't inherit from ActiveDOMObject somehow?
(In reply to Ryosuke Niwa from comment #2) > Comment on attachment 380801 [details] > Patch > > Can we also add a static_assert to make sure whatever object which is not > marked as ActiveDOMObject doesn't inherit from ActiveDOMObject somehow? I will give it a shot. It would be great to have indeed.
(In reply to Chris Dumez from comment #3) > (In reply to Ryosuke Niwa from comment #2) > > Comment on attachment 380801 [details] > > Patch > > > > Can we also add a static_assert to make sure whatever object which is not > > marked as ActiveDOMObject doesn't inherit from ActiveDOMObject somehow? > > I will give it a shot. It would be great to have indeed. Hopefully, a simple type traits or some of helper functions in https://en.cppreference.com/w/cpp/types should do the trick.
Created attachment 380815 [details] Patch
Created attachment 380816 [details] Patch
Comment on attachment 380816 [details] Patch Clearing flags on attachment: 380816 Committed r251040: <https://trac.webkit.org/changeset/251040>
All reviewed patches have been landed. Closing bug.
Looks like this introduced IDB debug assertion failures: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/r251040%20(6218)/results.html
(In reply to Ryosuke Niwa from comment #9) > Looks like this introduced IDB debug assertion failures: > https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/ > r251040%20(6218)/results.html :/ Will look.
We might want to roll it out for now since it broke some debug bots: https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20%28Tests%29/builds/5252 Bots are existing early after 50 failures.
Reverted r251040 for reason: Broke IDB tests in Debug Committed r251051: <https://trac.webkit.org/changeset/251051>
<rdar://problem/56222556>
Created attachment 380834 [details] Patch
Comment on attachment 380834 [details] Patch Clearing flags on attachment: 380834 Committed r251053: <https://trac.webkit.org/changeset/251053>