Bug 202869 - Add [ActiveDOMObject] to IDLs of ActiveDOMObjects
Summary: Add [ActiveDOMObject] to IDLs of ActiveDOMObjects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 202293
  Show dependency treegraph
 
Reported: 2019-10-11 16:46 PDT by Chris Dumez
Modified: 2019-10-12 16:40 PDT (History)
26 users (show)

See Also:


Attachments
Patch (8.36 KB, patch)
2019-10-11 16:49 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (86.31 KB, patch)
2019-10-11 21:20 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (85.27 KB, patch)
2019-10-11 21:25 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (85.81 KB, patch)
2019-10-12 14:14 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-10-11 16:46:06 PDT
Add [ActiveDOMObject] to IDLs of ActiveDOMObjects.
Comment 1 Chris Dumez 2019-10-11 16:49:30 PDT
Created attachment 380801 [details]
Patch
Comment 2 Ryosuke Niwa 2019-10-11 19:16:10 PDT
Comment on attachment 380801 [details]
Patch

Can we also add a static_assert to make sure whatever object which is not marked as ActiveDOMObject doesn't inherit from ActiveDOMObject somehow?
Comment 3 Chris Dumez 2019-10-11 19:58:55 PDT
(In reply to Ryosuke Niwa from comment #2)
> Comment on attachment 380801 [details]
> Patch
> 
> Can we also add a static_assert to make sure whatever object which is not
> marked as ActiveDOMObject doesn't inherit from ActiveDOMObject somehow?

I will give it a shot. It would be great to have indeed.
Comment 4 Ryosuke Niwa 2019-10-11 20:02:15 PDT
(In reply to Chris Dumez from comment #3)
> (In reply to Ryosuke Niwa from comment #2)
> > Comment on attachment 380801 [details]
> > Patch
> > 
> > Can we also add a static_assert to make sure whatever object which is not
> > marked as ActiveDOMObject doesn't inherit from ActiveDOMObject somehow?
> 
> I will give it a shot. It would be great to have indeed.

Hopefully, a simple type traits or some of helper functions in https://en.cppreference.com/w/cpp/types should do the trick.
Comment 5 Chris Dumez 2019-10-11 21:20:18 PDT
Created attachment 380815 [details]
Patch
Comment 6 Chris Dumez 2019-10-11 21:25:20 PDT
Created attachment 380816 [details]
Patch
Comment 7 Chris Dumez 2019-10-11 21:55:40 PDT
Comment on attachment 380816 [details]
Patch

Clearing flags on attachment: 380816

Committed r251040: <https://trac.webkit.org/changeset/251040>
Comment 8 Chris Dumez 2019-10-11 21:55:43 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Ryosuke Niwa 2019-10-12 13:59:03 PDT
Looks like this introduced IDB debug assertion failures:
https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/r251040%20(6218)/results.html
Comment 10 Chris Dumez 2019-10-12 13:59:51 PDT
(In reply to Ryosuke Niwa from comment #9)
> Looks like this introduced IDB debug assertion failures:
> https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/
> r251040%20(6218)/results.html

:/ Will look.
Comment 11 Ryosuke Niwa 2019-10-12 14:02:40 PDT
We might want to roll it out for now since it broke some debug bots:
https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20%28Tests%29/builds/5252

Bots are existing early after 50 failures.
Comment 12 Chris Dumez 2019-10-12 14:04:51 PDT
Reverted r251040 for reason:

Broke IDB tests in Debug

Committed r251051: <https://trac.webkit.org/changeset/251051>
Comment 13 Radar WebKit Bug Importer 2019-10-12 14:05:09 PDT
<rdar://problem/56222556>
Comment 14 Chris Dumez 2019-10-12 14:14:59 PDT
Created attachment 380834 [details]
Patch
Comment 15 WebKit Commit Bot 2019-10-12 16:40:12 PDT
Comment on attachment 380834 [details]
Patch

Clearing flags on attachment: 380834

Committed r251053: <https://trac.webkit.org/changeset/251053>
Comment 16 WebKit Commit Bot 2019-10-12 16:40:14 PDT
All reviewed patches have been landed.  Closing bug.