Bug 202865 - Clearing Website data for a given session should not shut down cached processes for other sessions
Summary: Clearing Website data for a given session should not shut down cached process...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 202660
Blocks: 202293
  Show dependency tree / graph
 
Reported: 2019-10-11 14:01 PDT by Chris Dumez
Modified: 2019-10-12 09:18 PDT (History)
7 users (show)

See Also:

Attachments
Patch (20.63 KB, patch)
2019-10-11 15:28 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (20.63 KB, patch)
2019-10-11 15:32 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (20.54 KB, patch)
2019-10-12 08:33 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-10-11 14:01:37 PDT 
Clearing Website data for a given session should do shut down cached processes (e.g. suspended processes for the back/forward cache) for other sessions.
Comment 1 Radar WebKit Bug Importer 2019-10-11 14:02:32 PDT 
<rdar://problem/56202912>
Comment 2 Chris Dumez 2019-10-11 15:28:41 PDT 
Created attachment 380794 [details]
Patch
Comment 3 Chris Dumez 2019-10-11 15:32:59 PDT 
Created attachment 380795 [details]
Patch
Comment 4 Antti Koivisto 2019-10-11 22:09:40 PDT 
Comment on attachment 380795 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380795&action=review

> Source/WebKit/UIProcess/WebProcessProxy.h:274
> +    class ScopePreventingShutdown {

It would be nice to have some sort of WTF template for this. The pattern shows up occasionally.

> Source/WebKit/UIProcess/WebProcessProxy.h:284
> +        ~ScopePreventingShutdown()
> +        {
> +            if (m_process) {

m_process can't be null here.

> Source/WebKit/UIProcess/WebProcessProxy.h:292
> +        RefPtr<WebProcessProxy> m_process;

Ref<>?
Comment 5 Chris Dumez 2019-10-12 08:33:14 PDT 
Created attachment 380827 [details]
Patch
Comment 6 WebKit Commit Bot 2019-10-12 09:17:59 PDT 
Comment on attachment 380827 [details]
Patch

Clearing flags on attachment: 380827

Committed r251048: <https://trac.webkit.org/changeset/251048>
Comment 7 WebKit Commit Bot 2019-10-12 09:18:01 PDT 
All reviewed patches have been landed.  Closing bug.