Bug 202865 – Clearing Website data for a given session should not shut down cached processes for other sessions

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Clearing Website data for a given session should do shut down cached processes (e.g. suspended processes for the back/forward cache) for other sessions.

[Radar WebKit Bug Importer]

<rdar://problem/56202912>

[Chris Dumez]

Created attachment 380794 [details]
Patch

[Chris Dumez]

Created attachment 380795 [details]
Patch

[Antti Koivisto]

Comment on attachment 380795 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380795&action=review

> Source/WebKit/UIProcess/WebProcessProxy.h:274
> +    class ScopePreventingShutdown {

It would be nice to have some sort of WTF template for this. The pattern shows up occasionally.

> Source/WebKit/UIProcess/WebProcessProxy.h:284
> +        ~ScopePreventingShutdown()
> +        {
> +            if (m_process) {

m_process can't be null here.

> Source/WebKit/UIProcess/WebProcessProxy.h:292
> +        RefPtr<WebProcessProxy> m_process;

Ref<>?

[Chris Dumez]

Created attachment 380827 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 380827 [details]
Patch

Clearing flags on attachment: 380827

Committed r251048: <https://trac.webkit.org/changeset/251048>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.