RESOLVED FIXED 202853
Remove some dead code in webkitpy's mac.py 
https://bugs.webkit.org/show_bug.cgi?id=202853
Summary Remove some dead code in webkitpy's mac.py
Blaze Burg
Reported 2019-10-11 10:47:24 PDT
.
Attachments
Patch (4.71 KB, patch)
2019-10-11 10:50 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2019-10-11 10:50:28 PDT
Created attachment 380764 [details] Patch
Jonathan Bedard
Comment 2 2019-10-11 10:56:00 PDT
Comment on attachment 380764 [details] Patch Looks good to me, but let's let EWS do it's thing, since if you were going to break something horribly, EWS would likely make it clear.
Alexey Proskuryakov
Comment 3 2019-10-11 12:36:33 PDT
Comment on attachment 380764 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380764&action=review > Tools/Scripts/webkitpy/port/mac.py:-272 > - # FIXME: Remove this after <rdar://problem/15605007> is fixed. > - logging_patterns.append((re.compile('(AVF|GVA) info:.*\n'), '')) Seeing other instances of similar logging from same sources below, I wonder if we should treat stripping that as a permanent feature.
WebKit Commit Bot
Comment 4 2019-10-11 13:35:12 PDT
Comment on attachment 380764 [details] Patch Clearing flags on attachment: 380764 Committed r251020: <https://trac.webkit.org/changeset/251020>
WebKit Commit Bot
Comment 5 2019-10-11 13:35:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-10-15 16:49:11 PDT
<rdar://problem/56313774>
Note You need to log in before you can comment on or make changes to this bug.