Bug 202853 - Remove some dead code in webkitpy's mac.py
Summary: Remove some dead code in webkitpy's mac.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-11 10:47 PDT by BJ Burg
Modified: 2019-10-15 16:49 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.71 KB, patch)
2019-10-11 10:50 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2019-10-11 10:47:24 PDT 
.
Comment 1 BJ Burg 2019-10-11 10:50:28 PDT 
Created attachment 380764 [details]
Patch
Comment 2 Jonathan Bedard 2019-10-11 10:56:00 PDT 
Comment on attachment 380764 [details]
Patch

Looks good to me, but let's let EWS do it's thing, since if you were going to break something horribly, EWS would likely make it clear.
Comment 3 Alexey Proskuryakov 2019-10-11 12:36:33 PDT 
Comment on attachment 380764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380764&action=review

> Tools/Scripts/webkitpy/port/mac.py:-272
> -        # FIXME: Remove this after <rdar://problem/15605007> is fixed.
> -        logging_patterns.append((re.compile('(AVF|GVA) info:.*\n'), ''))

Seeing other instances of similar logging from same sources below, I wonder if we should treat stripping that as a permanent feature.
Comment 4 WebKit Commit Bot 2019-10-11 13:35:12 PDT 
Comment on attachment 380764 [details]
Patch

Clearing flags on attachment: 380764

Committed r251020: <https://trac.webkit.org/changeset/251020>
Comment 5 WebKit Commit Bot 2019-10-11 13:35:13 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-10-15 16:49:11 PDT 
<rdar://problem/56313774>