Remove some support for < iOS 13 
https://bugs.webkit.org/show_bug.cgi?id=202822
Summary Remove some support for < iOS 13
Keith Rollin
Reported 2019-10-10 12:53:00 PDT
Remove some support for iOS versions less than 13.0. Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have values >= 130000. This means that expressions like "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True. This removal is part of a series of patches effecting the removal of dead code for old versions of iOS. This particular pass involves changes in which Eric Carlson was involved. These changes are isolated from other similar changes in order to facilitate the reviewing process.
Attachments
Patch (10.16 KB, patch)
2019-10-10 17:14 PDT, Keith Rollin 		krollin: review?
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-10-10 12:53:16 PDT
<rdar://problem/56165480>
Keith Rollin
Comment 2 2019-10-10 17:14:43 PDT
Created attachment 380704 [details] Patch
Alexey Proskuryakov
Comment 3 2019-10-11 10:10:13 PDT
Comment on attachment 380704 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380704&action=review This looks good, but a review from a media expert would be a good opportunity to confirm if we are actually doing what we want to do. > Source/WTF/wtf/Platform.h:1598 > +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || PLATFORM(IOS) || PLATFORM(WATCHOS) || PLATFORM(APPLETV) Strange that this excludes macCatalyst. > Tools/TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:141 > +#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(WATCHOS) || PLATFORM(APPLETV) Excluding macCatalyst again...
Note You need to log in before you can comment on or make changes to this bug.