Bug 202804 - Various test-cases from Gecko assert with ASSERTION FAILED: tagName == mmultiscriptsTag or ASSERTION FAILED: tagName == mrootTag
Summary: Various test-cases from Gecko assert with ASSERTION FAILED: tagName == mmulti...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-10 10:32 PDT by Emilio Cobos Álvarez (:emilio)
Modified: 2020-10-11 12:17 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.29 KB, patch)
2020-10-11 04:46 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (6.31 KB, patch)
2020-10-11 08:15 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (6.32 KB, patch)
2020-10-11 10:32 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emilio Cobos Álvarez (:emilio) 2019-10-10 10:32:54 PDT 
On master (247b0314320d499ae788b6ea993aa1d98e2d607e / r250962), WebKitGTK build.

The following files when ran locally fail the assertions in either:

 * https://webkit-search.igalia.com/webkit/rev/3994522544ee5be18e96c34640528f8a27462ee4/Source/WebCore/mathml/MathMLRootElement.cpp#45
 * https://webkit-search.igalia.com/webkit/rev/3994522544ee5be18e96c34640528f8a27462ee4/Source/WebCore/mathml/MathMLScriptsElement.cpp#55

Note that you may need to download them and run locally, otherwise CSP won't execute scripts (if any).

 * https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/generic/crashtests/368461-1.xhtml
 * https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/generic/crashtests/370884-1.xhtml
 * https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/generic/crashtests/382208-1.xhtml
 * https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/generic/crashtests/395450-1.xhtml
 * https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/generic/crashtests/472587-1.xhtml
 * https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/generic/crashtests/514098-1.xhtml
 * https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/mathml/crashtests/404485-1.xhtml
 * https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/mathml/crashtests/405271-1.xml
 * https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/mathml/crashtests/416907-1.xhtml
 * https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/style/crashtests/469432-1.xhtml
 * https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/style/crashtests/539613-1.xhtml
Comment 1 Rob Buis 2020-10-11 04:46:46 PDT 
Created attachment 411048 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2020-10-11 05:23:55 PDT 
Comment on attachment 411048 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411048&action=review

> LayoutTests/mathml/scripts-with-prefixes.xhtml:17
> +    <m:munderover/>

Please add one for mmultiscripts too.
Comment 3 Rob Buis 2020-10-11 08:15:10 PDT 
Created attachment 411052 [details]
Patch
Comment 4 EWS 2020-10-11 10:06:00 PDT 
Frederic Wang found in /Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 5 Rob Buis 2020-10-11 10:32:16 PDT 
Created attachment 411056 [details]
Patch
Comment 6 EWS 2020-10-11 12:16:53 PDT 
Committed r268324: <https://trac.webkit.org/changeset/268324>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411056 [details].
Comment 7 Radar WebKit Bug Importer 2020-10-11 12:17:18 PDT 
<rdar://problem/70184786>