Bug 202779 - [Mac] Update fast/text/font-cursive-italic-cjk-2.html for Catalina
Summary: [Mac] Update fast/text/font-cursive-italic-cjk-2.html for Catalina
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-09 19:28 PDT by Myles C. Maxfield
Modified: 2019-10-14 17:59 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.17 KB, patch)
2019-10-09 19:29 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (2.25 KB, patch)
2019-10-10 11:47 PDT, Myles C. Maxfield 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2019-10-09 19:28:12 PDT 
[Mac] Update fast/text/font-cursive-italic-cjk-2.html for Catalina
Comment 1 Myles C. Maxfield 2019-10-09 19:29:21 PDT 
Created attachment 380601 [details]
Patch
Comment 2 Myles C. Maxfield 2019-10-09 19:29:24 PDT 
<rdar://problem/54317204>
Comment 3 Alexey Proskuryakov 2019-10-09 21:00:08 PDT 
Comment on attachment 380601 [details]
Patch

I suggest adding a new test alongside the old one. The platform directory is really only for expectations, as putting tests there often results in a lot of confusion about where to put their results (admittedly not an issue for this reftest, but nonetheless).
Comment 4 Myles C. Maxfield 2019-10-10 11:47:21 PDT 
Created attachment 380667 [details]
Patch
Comment 5 Alexey Proskuryakov 2019-10-10 22:17:09 PDT 
Comment on attachment 380667 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380667&action=review

> LayoutTests/platform/mac/TestExpectations:1173
> +[ Catalina+ ] fast/text/font-cursive-italic-cjk-2.html [ ImageOnlyFailure ]

May be worth adding a comment saying that this test can be deleted when Catalina is the oldest supported OS.
Comment 6 Myles C. Maxfield 2019-10-14 13:52:29 PDT 
Committed r251092: <https://trac.webkit.org/changeset/251092>
Comment 7 Myles C. Maxfield 2019-10-14 17:59:55 PDT 
Committed r251115: <https://trac.webkit.org/changeset/251115>