Bug 202769 – Web Inspector: Modifying CSS selector by pressing Enter or Tab causes 2 CSS.setRuleSelector backend calls

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Editing a selector in the style editor causes at least two backend calls with the same data. There should be only one backend call.

[Log] Trace: request (page-26) – {id: 124, method: "CSS.setRuleSelector", params: {ruleId: {styleSheetId: "1", ordinal: 1}, selector: "foo"}}
	changeRuleSelector (DOMNodeStyles.js:439)
	selectorText (CSSRule.js:76)
	spreadsheetSelectorFieldDidChange (SpreadsheetCSSStyleDeclarationSection.js:238)
	_handleKeyDown (SpreadsheetSelectorField.js:135)
	_handleKeyDown
[Log] Trace: request (page-26) – {id: 126, method: "CSS.setRuleSelector", params: {ruleId: {styleSheetId: "1", ordinal: 1}, selector: "foo"}}
	changeRuleSelector (DOMNodeStyles.js:439)
	selectorText (CSSRule.js:76)
	spreadsheetSelectorFieldDidChange (SpreadsheetCSSStyleDeclarationSection.js:238)
	_handleBlur (SpreadsheetSelectorField.js:113)
	_handleBlur
	focus
	startEditing (SpreadsheetTextField.js:101)
	startEditingName (SpreadsheetStyleProperty.js:109)
	startEditingFirstProperty (SpreadsheetCSSStyleDeclarationEditor.js:258)
	spreadsheetSelectorFieldDidChange (SpreadsheetCSSStyleDeclarationSection.js:247)
	_handleKeyDown (SpreadsheetSelectorField.js:135)
	_handleKeyDown

[Radar WebKit Bug Importer]

<rdar://problem/56132166>

[Nikita Vasilyev]

Created attachment 380583 [details]
Patch

[Matt Baker]

Comment on attachment 380583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380583&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetSelectorField.js:115
> +            this._delegate.spreadsheetSelectorFieldDidCommit(changed);

Should we just skip calling `this._delegate.spreadsheetSelectorFieldDidCommit` altogether if !changed, instead of passing it as an argument?

[Nikita Vasilyev]

Created attachment 380588 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 380588 [details]
Patch

Clearing flags on attachment: 380588

Committed r250948: <https://trac.webkit.org/changeset/250948>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Nikita Vasilyev]

Comment on attachment 380583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380583&action=review

>> Source/WebInspectorUI/UserInterface/Views/SpreadsheetSelectorField.js:115
>> +            this._delegate.spreadsheetSelectorFieldDidCommit(changed);
> 
> Should we just skip calling `this._delegate.spreadsheetSelectorFieldDidCommit` altogether if !changed, instead of passing it as an argument?

Turns out this wasn't such a good idea :D
Bug 202781 - REGRESSION(r250948): Web Inspector: Styles: CSS selector becomes gray after stopping editing without modifying it