Bug 202763 – [WinCairo] Move remote communication handling from RemoteInspectorServer to RemoteInspector.

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Basuke Suzuki]

Because RemoteInspector now exists in UIProcess, the old method which communicate with RemoteInspector in WebProcess and RemoteInspectorServer in UIProcess was meaningless or even bad. Remove this complex implementation and move communication handling from RemoteInspectorServer to directly RemoteInspector.

[Basuke Suzuki]

Created attachment 380568 [details]
PATCH

[Basuke Suzuki]

Created attachment 380575 [details]
PATCH

style fix

[Ross Kirsling]

Comment on attachment 380575 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=380575&action=review

> Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorServer.cpp:32
> +

Nit: You don't need a newline here (since it's RemoteInspectorMessageParser.h, not RemoteInspectorServer.h).

> Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorServer.h:49
> +    void didClose(ConnectionID) override { };

Nit: No semicolon needed.

> Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:106
> +#if PLATFORM(PLAYSTATION) || PLATFORM(WIN)

Maybe this should be USE(GENERIC_EVENT_LOOP) || USE(WINDOWS_EVENT_LOOP) ?

[Basuke Suzuki]

Comment on attachment 380575 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=380575&action=review

>> Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorServer.h:49
>> +    void didClose(ConnectionID) override { };
> 
> Nit: No semicolon needed.

Wow. Yes. It should be handled by style-checker!

>> Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:106
>> +#if PLATFORM(PLAYSTATION) || PLATFORM(WIN)
> 
> Maybe this should be USE(GENERIC_EVENT_LOOP) || USE(WINDOWS_EVENT_LOOP) ?

That's right. Actually it is handle if every port has RunLoop::iterate() like WebCore::EventLoop::cycle()

[Basuke Suzuki]

Created attachment 380676 [details]
PATCH

[WebKit Commit Bot]

Comment on attachment 380676 [details]
PATCH

Clearing flags on attachment: 380676

Committed r250988: <https://trac.webkit.org/changeset/250988>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56169349>