Bug 202763 - [WinCairo] Move remote communication handling from RemoteInspectorServer to RemoteInspector.
Summary: [WinCairo] Move remote communication handling from RemoteInspectorServer to R...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-09 13:13 PDT by Basuke Suzuki
Modified: 2019-10-10 14:21 PDT (History)
13 users (show)

See Also:

Attachments
PATCH (41.18 KB, patch)
2019-10-09 14:49 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
PATCH (41.18 KB, patch)
2019-10-09 15:02 PDT, Basuke Suzuki 		ross.kirsling: review+
Details | Formatted Diff | Diff
PATCH (41.13 KB, patch)
2019-10-10 13:33 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2019-10-09 13:13:22 PDT 
Because RemoteInspector now exists in UIProcess, the old method which communicate with RemoteInspector in WebProcess and RemoteInspectorServer in UIProcess was meaningless or even bad. Remove this complex implementation and move communication handling from RemoteInspectorServer to directly RemoteInspector.
Comment 1 Basuke Suzuki 2019-10-09 14:49:00 PDT 
Created attachment 380568 [details]
PATCH
Comment 2 Basuke Suzuki 2019-10-09 15:02:00 PDT 
Created attachment 380575 [details]
PATCH

style fix
Comment 3 Ross Kirsling 2019-10-09 18:23:06 PDT 
Comment on attachment 380575 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=380575&action=review

> Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorServer.cpp:32
> +

Nit: You don't need a newline here (since it's RemoteInspectorMessageParser.h, not RemoteInspectorServer.h).

> Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorServer.h:49
> +    void didClose(ConnectionID) override { };

Nit: No semicolon needed.

> Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:106
> +#if PLATFORM(PLAYSTATION) || PLATFORM(WIN)

Maybe this should be USE(GENERIC_EVENT_LOOP) || USE(WINDOWS_EVENT_LOOP) ?
Comment 4 Basuke Suzuki 2019-10-10 13:32:08 PDT 
Comment on attachment 380575 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=380575&action=review

>> Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorServer.h:49
>> +    void didClose(ConnectionID) override { };
> 
> Nit: No semicolon needed.

Wow. Yes. It should be handled by style-checker!

>> Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:106
>> +#if PLATFORM(PLAYSTATION) || PLATFORM(WIN)
> 
> Maybe this should be USE(GENERIC_EVENT_LOOP) || USE(WINDOWS_EVENT_LOOP) ?

That's right. Actually it is handle if every port has RunLoop::iterate() like WebCore::EventLoop::cycle()
Comment 5 Basuke Suzuki 2019-10-10 13:33:44 PDT 
Created attachment 380676 [details]
PATCH
Comment 6 WebKit Commit Bot 2019-10-10 14:20:19 PDT 
Comment on attachment 380676 [details]
PATCH

Clearing flags on attachment: 380676

Committed r250988: <https://trac.webkit.org/changeset/250988>
Comment 7 WebKit Commit Bot 2019-10-10 14:20:20 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-10-10 14:21:23 PDT 
<rdar://problem/56169349>