Bug 202762 - Back/Forward cache does not work after doing a favorite navigation
Summary: Back/Forward cache does not work after doing a favorite navigation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 202293
  Show dependency tree / graph
 
Reported: 2019-10-09 12:45 PDT by Chris Dumez
Modified: 2019-10-12 12:17 PDT (History)
9 users (show)

See Also:

Attachments
Patch (11.36 KB, patch)
2019-10-09 13:15 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (11.35 KB, patch)
2019-10-12 09:38 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-10-09 12:45:26 PDT 
Back/Forward cache does not work after doing a favorites navigation. The reason is that Safari forces a process-swap, and we close the page in in the previous process to break potential opener links. This is making it impossible to go back to that cached page.
Comment 1 Radar WebKit Bug Importer 2019-10-09 12:57:10 PDT 
<rdar://problem/56126911>
Comment 2 Chris Dumez 2019-10-09 13:15:24 PDT 
Created attachment 380559 [details]
Patch
Comment 3 Chris Dumez 2019-10-11 13:17:50 PDT 
ping review?
Comment 4 WebKit Commit Bot 2019-10-12 09:20:26 PDT 
Comment on attachment 380559 [details]
Patch

Rejecting attachment 380559 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 380559, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=380559&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=202762&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 380559 from bug 202762.
Fetching: https://bugs.webkit.org/attachment.cgi?id=380559
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 9 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/history/CachedFrame.cpp
Hunk #1 succeeded at 179 (offset -1 lines).
patching file Source/WebCore/loader/FrameLoader.cpp
patching file Source/WebCore/loader/FrameLoader.h
patching file Source/WebKit/UIProcess/WebPageProxy.cpp
Hunk #1 FAILED at 785.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/UIProcess/WebPageProxy.cpp.rej
patching file Source/WebKit/WebProcess/WebPage/WebPage.cpp
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
Hunk #1 succeeded at 3224 (offset -49 lines).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/13123562
Comment 5 Chris Dumez 2019-10-12 09:38:10 PDT 
Created attachment 380829 [details]
Patch
Comment 6 WebKit Commit Bot 2019-10-12 12:17:45 PDT 
Comment on attachment 380829 [details]
Patch

Clearing flags on attachment: 380829

Committed r251049: <https://trac.webkit.org/changeset/251049>
Comment 7 WebKit Commit Bot 2019-10-12 12:17:47 PDT 
All reviewed patches have been landed.  Closing bug.