Bug 202757 - results.webkit.org: Increase default limit for test results
Summary: results.webkit.org: Increase default limit for test results
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-09 10:40 PDT by Jonathan Bedard
Modified: 2019-12-16 15:15 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.89 KB, patch)
2019-10-09 10:46 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (3.89 KB, patch)
2019-10-09 11:49 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-10-09 10:40:35 PDT 
We should increase the default limit for test results from 1000 to 5000. I don't think this should apply to commits.
Comment 1 Jonathan Bedard 2019-10-09 10:46:10 PDT 
Created attachment 380543 [details]
Patch
Comment 2 Aakash Jain 2019-10-09 11:44:59 PDT 
Comment on attachment 380543 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380543&action=review

rs=me

> Tools/ChangeLog:3
> +        results.webkit.org: Increase default limit for test results

which limit? Is it the limit of data being displayed somewhere?
Comment 3 Jonathan Bedard 2019-10-09 11:47:25 PDT 
(In reply to Aakash Jain from comment #2)
> Comment on attachment 380543 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=380543&action=review
> 
> rs=me
> 
> > Tools/ChangeLog:3
> > +        results.webkit.org: Increase default limit for test results
> 
> which limit? Is it the limit of data being displayed somewhere?

Yes, the number of result bubbles to be shown. It's mostly about the UI.
Comment 4 Jonathan Bedard 2019-10-09 11:49:39 PDT 
Created attachment 380549 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-10-09 12:57:14 PDT 
Comment on attachment 380549 [details]
Patch for landing

Clearing flags on attachment: 380549

Committed r250924: <https://trac.webkit.org/changeset/250924>
Comment 6 WebKit Commit Bot 2019-10-09 12:57:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-10-09 12:58:16 PDT 
<rdar://problem/56126968>
Comment 8 Jonathan Bedard 2019-10-10 08:19:49 PDT 
Committed r250970: <https://trac.webkit.org/changeset/250970>