Bug 202748 - JSC does not compile on 32bits in Debug mode
Summary: JSC does not compile on 32bits in Debug mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Paulo Matos
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2019-10-09 06:30 PDT by Paulo Matos
Modified: 2019-10-14 08:38 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paulo Matos 2019-10-09 06:30:00 PDT 
Since bug 202509 got fixed, we cannot build JSC 32bits in Debug mode.

It fails with:
FAILED: DerivedSources/JavaScriptCore/LLIntAssembly.h 
cd /home/pmatos/Projects/igalia/WebKit/WebKitBuild/Debug/DerivedSources/JavaScriptCore && /usr/bin/ruby /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/asm.rb -I/home/pmatos/Projects/igalia/WebKit/WebKitBuild/Debug/DerivedSources/JavaScriptCore/ /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter.asm /home/pmatos/Projects/igalia/WebKit/WebKitBuild/Debug/bin/LLIntOffsetsExtractor /home/pmatos/Projects/igalia/WebKit/WebKitBuild/Debug/DerivedSources/JavaScriptCore/LLIntAssembly.h && /usr/bin/cmake -E touch_nocreate /home/pmatos/Projects/igalia/WebKit/WebKitBuild/Debug/DerivedSources/JavaScriptCore/LLIntAssembly.h
/home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/transform.rb:621:in `validate': Unresolved temp at /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:782 (RuntimeError)
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/transform.rb:627:in `block in validateChildren'
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/transform.rb:625:in `each'
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/transform.rb:625:in `validateChildren'
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/transform.rb:689:in `validate'
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/transform.rb:627:in `block in validateChildren'
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/transform.rb:625:in `each'
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/transform.rb:625:in `validateChildren'
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/transform.rb:634:in `validate'
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/asm.rb:403:in `block (3 levels) in <main>'
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/settings.rb:107:in `forSettings'
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/asm.rb:390:in `block (2 levels) in <main>'
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/asm.rb:386:in `each'
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/asm.rb:386:in `block in <main>'
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/asm.rb:376:in `open'
	from /home/pmatos/Projects/igalia/WebKit/Source/JavaScriptCore/offlineasm/asm.rb:376:in `<main>'

In Release mode, JSC builds successfully but a ton of tests fail with a segmentation fault. I am left wondering why the `validate` seems to be happy in Release and raises an error in Debug mode. I am investigating this issue at the moment, but I am happy to discuss possible issues, if anyone has an idea of what is going wrong.
Comment 1 Paulo Matos 2019-10-09 06:31:12 PDT 
Apologies - I meant since but 202569 :  [JSC] Change signature of HostFunction to (JSGlobalObject*, CallFrame*)
Comment 2 Yusuke Suzuki 2019-10-11 16:33:34 PDT 
This is non-CLoop 32bit issue (32bit JIT enabled JSC) and fixed in r250982.
Comment 3 Paulo Matos 2019-10-14 08:38:22 PDT 
(In reply to Yusuke Suzuki from comment #2)
> This is non-CLoop 32bit issue (32bit JIT enabled JSC) and fixed in r250982.

Thanks - I confirm. Closing.