Bug 202732 – [WPE] Several adClickAttribution tests are failing of flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Miguel Gomez]

This test is failing since r249613:
http/tests/adClickAttribution/clear-through-website-data-removal.html [ Failure ]

with this diff:

--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/http/tests/adClickAttribution/clear-through-website-data-removal-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/http/tests/adClickAttribution/clear-through-website-data-removal-actual.txt
@@ -1,5 +1,19 @@
 Tests that both unconverted and converted attributions are cleared on website data removal.
 
 
+Unconverted Ad Click Attributions:
+WebCore::AdClickAttribution 1
+Source: localhost
+Destination: 127.0.0.1
+Campaign ID: 4
+No conversion data.
 
-No stored Ad Click Attribution data.
+Converted Ad Click Attributions:
+WebCore::AdClickAttribution 2
+Source: 127.0.0.1
+Destination: localhost
+Campaign ID: 3
+Conversion data: 12
+Conversion priority: 4
+Conversion earliest time to send: Within 24-48 hours
+Conversion request sent: false




Then there are a couple that are failing or crashing (there are no traces of the crashes but I guess it's the same as the tests below)

http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html [ Failure Crash ]
--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session-actual.txt
@@ -7,9 +7,5 @@
 --------
 Conversion not received - timed out.
 
-Unconverted Ad Click Attributions:
-WebCore::AdClickAttribution 1
-Source: 127.0.0.1
-Destination: localhost
-Campaign ID: 3
-No conversion data.
+
+No stored Ad Click Attribution data.


http/tests/adClickAttribution/send-attribution-conversion-request.html [ Failure Crash ]

--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/http/tests/adClickAttribution/send-attribution-conversion-request-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/http/tests/adClickAttribution/send-attribution-conversion-request-actual.txt
@@ -5,20 +5,20 @@
 --------
 Frame: '<!--frame1-->'
 --------
-Cookies are: cookieSetAsFirstParty = 1
+Cookies are: cookieSetAsFirstParty = 1 cookieSetInConversionReport = 1
 
 --------
 Frame: '<!--frame2-->'
 --------
 Conversion received.
 HTTP_HOST: 127.0.0.1:8000
+Cookies in conversion request: cookieSetAsFirstParty=1
 REQUEST_URI: /adClickAttribution/resources/conversionReport.php?conversion=12&campaign=3
-No cookies in conversion request.
 
 
 --------
 Frame: '<!--frame3-->'
 --------
-Cookies are: cookieSetAsFirstParty = 1
+Cookies are: cookieSetAsFirstParty = 1 cookieSetInConversionReport = 1
 
 No stored Ad Click Attribution data.



And then there are four of them that are passing or crashing:
http/tests/adClickAttribution/expired-attributions-removed.html [ Crash Pass ]
http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html [ Crash Pass ]
http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html [ Crash Pass ]
http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html [ Crash Pass]

The backtrace when they crash is this:

Thread 1 (Thread 0x7f5d2db2ee40 (LWP 25999)):
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x00007f5d2ef46535 in __GI_abort () at abort.c:79
#2  0x000055c193072beb in WPEToolingBackends::HeadlessViewBackend::displayBuffer(wpe_fdo_egl_exported_image*) [clone .cold.6] ()
#3  0x00007f5d335b9c98 in (anonymous namespace)::ClientBundleEGL::exportImage(wpe_fdo_egl_exported_image*) () from /home/buildbot/wpe/wpe-linux-64-release-tests/build/WebKitBuild/DependenciesWPE/Root/lib/libWPEBackend-fdo-1.0.so.1
#4  0x00007f5d335b9bc3 in (anonymous namespace)::ClientBundleEGL::exportBuffer(linux_dmabuf_buffer const*) () from /home/buildbot/wpe/wpe-linux-64-release-tests/build/WebKitBuild/DependenciesWPE/Root/lib/libWPEBackend-fdo-1.0.so.1
#5  0x00007f5d335b3666 in ViewBackend::exportLinuxDmabuf(linux_dmabuf_buffer const*) () from /home/buildbot/wpe/wpe-linux-64-release-tests/build/WebKitBuild/DependenciesWPE/Root/lib/libWPEBackend-fdo-1.0.so.1
#6  0x00007f5d335b42b6 in WS::{lambda(wl_client*, wl_resource*)#10}::operator()(wl_client*, wl_resource*) const () from /home/buildbot/wpe/wpe-linux-64-release-tests/build/WebKitBuild/DependenciesWPE/Root/lib/libWPEBackend-fdo-1.0.so.1
#7  0x00007f5d335b4308 in WS::{lambda(wl_client*, wl_resource*)#10}::_FUN(wl_client*, wl_resource*) () from /home/buildbot/wpe/wpe-linux-64-release-tests/build/WebKitBuild/DependenciesWPE/Root/lib/libWPEBackend-fdo-1.0.so.1
#8  0x00007f5d2e1ee162 in ffi_call_unix64 () from /home/buildbot/wpe/wpe-linux-64-release-tests/build/WebKitBuild/DependenciesWPE/Root/lib/libffi.so.5
#9  0x00007f5d2e1ed9f5 in ffi_call (cif=<optimized out>, fn=<optimized out>, rvalue=<optimized out>, avalue=<optimized out>) at /home/buildbot/wpe/wpe-linux-64-release-tests/build/WebKitBuild/DependenciesWPE/Source/libffi-3.0.10/src/x86/ffi64.c:486
#10 0x00007f5d2f43ab2d in ?? () from /usr/lib/x86_64-linux-gnu/libwayland-server.so.0
#11 0x00007f5d2f4375a9 in ?? () from /usr/lib/x86_64-linux-gnu/libwayland-server.so.0
#12 0x00007f5d2f438b72 in wl_event_loop_dispatch () from /usr/lib/x86_64-linux-gnu/libwayland-server.so.0
#13 0x00007f5d335b3e83 in WS::ServerSource::{lambda(_GSource*, int (*)(void*), void*)#3}::operator()(_GSource*, int (*)(void*), void*) const () from /home/buildbot/wpe/wpe-linux-64-release-tests/build/WebKitBuild/DependenciesWPE/Root/lib/libWPEBackend-fdo-1.0.so.1
#14 0x00007f5d335b3eea in WS::ServerSource::{lambda(_GSource*, int (*)(void*), void*)#3}::_FUN(_GSource*, int (*)(void*), void*) () from /home/buildbot/wpe/wpe-linux-64-release-tests/build/WebKitBuild/DependenciesWPE/Root/lib/libWPEBackend-fdo-1.0.so.1
#15 0x00007f5d3367680e in g_main_dispatch (context=0x55c1935aa650) at ../../Source/glib-2.58.1/glib/gmain.c:3182
#16 g_main_context_dispatch (context=context@entry=0x55c1935aa650) at ../../Source/glib-2.58.1/glib/gmain.c:3847
#17 0x00007f5d33676a78 in g_main_context_iterate (context=0x55c1935aa650, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../../Source/glib-2.58.1/glib/gmain.c:3920
#18 0x00007f5d33676d62 in g_main_loop_run (loop=0x55c1935ab850) at ../../Source/glib-2.58.1/glib/gmain.c:4116
#19 0x00007f5d37fcdae0 in WTF::RunLoop::run() () from /home/buildbot/wpe/wpe-linux-64-release/build/WebKitBuild/Release/lib/libWPEWebKit-1.0.so.3
#20 0x000055c1930a62f2 in WTR::TestController::platformRunUntil(bool&, WTF::Seconds) ()
#21 0x000055c193092731 in WTR::TestInvocation::invoke() ()
#22 0x000055c193083e26 in WTR::TestController::runTest(char const*) ()
#23 0x000055c1930845a5 in WTR::TestController::runTestingServerLoop() ()
#24 0x000055c193084948 in WTR::TestController::TestController(int, char const**) ()
#25 0x000055c193072c25 in main ()

[Diego Pino]

Fixed by r257726.